Feature request procedure?

Bjørn Mork bjorn at mork.no
Fri May 16 17:46:33 CEST 2008


"Tuc at T-B-O-H.NET" <ml at t-b-o-h.net> writes:

> 	Is there a procedure to follow to ask for a new feature to be added?

AFAIK:
 - develop a patch
 - create a bug report requesting the new feature
 - attach the patch to the report

> 	I seem to have some sort of anomoly that sqltrace is active in my server
> even though its not in debug mode. Thats not a big deal.
>
> 	What I would like, though, is in src/modules/rlm_sql/sql.c for a 
> timestamp to prepend the sql output. I'm trying to track down the last time
> a specific unit sent an accounting record, and I'd like to track it down to
> a time. Unfortunately, the sql statement is :
>
>            UPDATE radacct           SET              framedipaddress = '192.168.182.2',              acctsessiontime     = '4032',              acctinputoctets     = '0'  << 32 |                                    '4028824',              acctoutputoctets    = '0' << 32 |                                    '2535198'           WHERE acctsessionid = '481f035100000001'           AND username        = 'gasmac6'           AND nasipaddress    = '192.168.50.35';
>
> 	I realize I could add acctsessiontime to the original :
>
>            INSERT INTO radacct             (acctsessionid,    acctuniqueid,     username,              realm,            nasipaddress,     nasportid,              nasporttype,      acctstarttime,    acctstoptime,              acctsessiontime,  acctauthentic,    connectinfo_start,              connectinfo_stop, acctinputoctets,  acctoutputoctets,              calledstationid,  callingstationid, acctterminatecause,              servicetype,      framedprotocol,   framedipaddress,              acctstartdelay,   acctstopdelay,    xascendsessionsvrkey)           VALUES             ('481f035100000001', 'dbbf6395a6c658d9',              'gasmac6',              '', '192.168.50.35', '1',              'Wireless-802.11', '2008-05-05 13:11:36', NULL,              '0', '', '',              '', '0', '0',              '00-16-01-D2-AE-F8', '00-13-02-B5-79-7C', '',              '', '', '192.168.182.2',              '0', '0', '');
>
> 	and come up with the time... But I'd prefer to have confirmation it was
> 4032 later in reality.

I'm not sure if I understand exactly what you want to do, but if the
only thing you need is a modification timestamp, and you are using
MySQL, then you can make MySQL do this for you: Just add a "timestamp"
type column to the radacct table.  MySQL will automatically update it
whenever an entry is modified.  See
http://dev.mysql.com/doc/refman/5.0/en/timestamp.html


Bjørn




More information about the Freeradius-Users mailing list