Handling of duplicates in clients.conf

[Garber, Neal]

I'm running FR 2.0.3 and I just found that if there is more than one
client with the same IP address in clients.conf, then it will stop
processing the remainder of the file and continue startup.  The only
indication it has done this are 2 error messages that are easily missed
when running with debug on.  I checked git.freeradius.org and noticed
that the client.c committed on 09-March now ignores duplicates if they
are exactly the same.  In my case, everything was the same except the
name.  My question is, wouldn't it be better to continue processing the
remainder of the file even when there are duplicates that aren't
identical or alternatively to preclude the server from starting (I'd
vote for the former).  Ignoring what could be hundreds of clients that
follow the error doesn't seem useful.  

 

I propose ignoring all duplicates and having client_add return ok (1).
This would log the error for any duplicates (even duplicates that aren't
completely identical), but allow processing to continue for the
remainder of the file.

 

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20090326/fc008575/attachment.html>