home server debugging issues

[Josip Rodin]

On Thu, Nov 26, 2009 at 06:17:29PM +0100, Alan DeKok wrote:
> >         RDEBUG2("No response to status check %d from home server %s port %d",
> >         RDEBUG2("Proxying request %d to home server %s port %d",
> >         RDEBUG2("ERROR: Failed to find live home server for realm %s",
> >         RDEBUG2("Failed to find live home server for request %d", request->number);
> > 
> > It doesn't make sense for both error and debug messages to be displayed on
> > the same debug level. The error messages need to have priority, so that the
> > admin actually has a chance to see them.
> 
>   Some errors shouldn't be printed to the logs.  i.e. "no response to
> request".  If you're proxying 100's of packets/s and the home server
> dies, you are going to get a LOT of messages in the log.  This isn't
> desirable.
> 
>   Instead, various state changes (home server up / down) are logged.
> 
> > In this particular situation, when I move from debug level 0 to 2 in order
> > to oversee these events, I get not only these messages, but gobs of rlm_sql
> > expansions, unlang processing logs, etc.
> > 
> > It would be better if some of those error messages were upgraded to L_ERR,
> > or L_PROXY, while keeping the truely informational messages as L_DBG.
> > In fact it looks like there's only a single reference to L_PROXY in the
> > entire file.
> > 
> > Does this make sense, can I submit patches?
> 
>   I've committed a bunch of changes to the logging in src/main/event.c.
>  More events are logged, and there's a lot more use of L_PROXY.

Thanks, those commits are exactly what I meant.

-- 
     2. That which causes joy or happiness.