FR 2.1.9 Frequent SegFault, didn't happen with FR 2.1.8

[Alan DeKok]

Josip Rodin wrote:
> That code has indeed changed from 2.1.8 to 2.1.9, and it may be a simple bug
> - there is no existence check for request->packet before its dereference in
> the new CoA-related condition. There is an existence check for it below,
> but by then it's too late. It looks like that branching could do with some
> more reordering.

  Yes.  The code to fix a CoA bug caused another one.  <sigh>

  The server is quickly getting to the point where it's doing so much
that any small change can have large implications.

  The solution is to start re-organizing the code in the server core,
and simplifying it.  When 2.0 cam out, the code was much simpler than
1.x for the same functionality.  Three years later, added functionality
makes the code more complicated again.

  Alan DeKok.