radmin del client error

[Arran Cudbard-Bell]

On 24 Aug 2011, at 12:50, Bjørn Mork wrote:

> tohaikmeng <tohaikmeng at live.com> writes:
> 
>> [root at FC-O ~]# radmin -e "del client ipaddr"
>> ERROR: Must specify <ipaddr>
>> [root at FC-O ~]# radmin -e "del client ipaddr <ipaddr> 192.168.169.74"
>> ERROR: Client 192.168.169.74 was not dynamically defined.
> 
> Yes, that looks true even with yesterday's patch, provided "<ipaddr>"
> actually resolves to a non dynamic client...
> 
> I forgot that specific error path.  It's fixed by this:
> 
> diff --git a/src/main/command.c b/src/main/command.c
> index 8377d21..f2d3bc2 100644
> --- a/src/main/command.c
> +++ b/src/main/command.c
> @@ -1818,7 +1818,7 @@ static int command_del_client(rad_listen_t *listener, int argc, char *argv[])
>        if (!client) return 0;
> 
>        if (!client->dynamic) {
> -               cprintf(listener, "ERROR: Client %s was not dynamically defined.\n", argv[1]);
> +               cprintf(listener, "ERROR: Client %s was not dynamically defined.\n", argv[0]);
>                return 0;
>        }
> 
> 
> Bjørn
> 

Thanks, pulled and merged to 2.1.x

-Arran

Arran Cudbard-Bell
a.cudbardb at freeradius.org

RADIUS - Half the complexity of Diameter