acct segfault in git v2.1.x

[Alan DeKok]

Alexander Clouter wrote:
> Updating to git's v2.1.x to go on a post-Easter bughunt and found the 
> following accounting packet[1] seems to segfault freeradius:
...
> #1  0x403075d8 in fnmatch () from /lib/libc.so.6
> #2  0x409da598 in do_detail (instance=0x114e50, request=0x43443240, packet=0x43446dd8, compat=<value optimized out>) at rlm_detail.c:301

  Hmm... calling fnmatch() when the packet was *not* read from the
detail file is a bad idea.  Oops.

  On closer inspection, much of the logic in rlm_detail is broken.

> If you need the FreeRADIUS -X malarkey, then do ask, it is just tricker 
> to get on a production box... :)

  Nah.  I think the Feynman method is fine.

1) look at problem
2) think hard
3) write down solution

  Give me a bit and I'll push a change to "git".

  Alan DeKok.