request_dequeue problems (recent 3.0, when home-server stalls)

[Alan DeKok]

Brian Julin wrote:
> I'm currently hunting a problem that causes a recent checkout of FR3.0
> to abort but which does not seem to be affecting an older revision
> (April 8th or so)
> of FR3.0 on another box.  I do have a couple small in-house patches applied
> but they should probably not be relevant.

  It's always worth checking.

> The issue seems to happen when a home-server does not respond to a request,
> and then FR re-enqueues the request as a retransmit.  The request then gets
> dequeued again, and at that point fails a REQUEST_MAGIC assert.  That is,
> if I am reading the logs correctly...

  OK.

> Logs are included, with a few added printfs thrown in.
> 
> Anyone have any suggestions for good commits to bisect at?

  There aren't really many changes to process.c.  That's the key
function behind all of this.

> request_dequeue found request 0x13d5220
> ASSERT FAILED threads.c[468]: request->magic == REQUEST_MAGIC

  Which means that the request has been deleted, but is still in the
queue.  That's not supposed to happen...

  Alan DeKok.