radsqlrelay: can't it just give up sometimes?

Stefan Winter stefan.winter at restena.lu
Wed Nov 6 09:44:48 CET 2013


Hi,

> The joys of broken NAS kit. We've used a bit of unlang in our config for
> accounting for years to skip illegal packets. I think the default config
> now has similar?

It still doesn't catch everything, and I keep chasing corner cases every
once in a while (after losing stats due to queued SQL in radsqlrelay :-( ).

Looking at 3.0 mysql:queries.conf I see a Stop record:

UPDATE ${....acct_table2} SET
acctstoptime    = FROM_UNIXTIME(%{integer:Event-Timestamp}),
acctsessiontime = '%{Acct-Session-Time}',
...

which is the exact thing that broke: in its wisdom, a new NAS did NOT
include Acct-Session-Time in its Stop packets, which turned the
statement into

acctsessiontime = '',

which triggered the integer error in my original posting. I don't see
AcctSessionTime mangling anywhere in raddb, so don't think this would be
caught by unlang.

Of course the proper fix would be to then calculate
SessionTime = (StopTime-StartTime), but the far more convenient fix for
me was

acctsessiontime = '%{%{Acct-Session-Time}:-0}',

since it's just a worthless eduroam accounting table which we don't make
much use of anyway.

I would still much appreciate if such kinds of errors wouldn't clog up
the query queue.

Greetings,

Stefan Winter

-- 
Stefan WINTER
Ingenieur de Recherche
Fondation RESTENA - Réseau Téléinformatique de l'Education Nationale et
de la Recherche
6, rue Richard Coudenhove-Kalergi
L-1359 Luxembourg

Tel: +352 424409 1
Fax: +352 422473

PGP key updated to 4096 Bit RSA - I will encrypt all mails if the
recipient's key is known to me

http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xC0DE6A358A39DC66
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0x8A39DC66.asc
Type: application/pgp-keys
Size: 3243 bytes
Desc: not available
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20131106/cb4d6eb0/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20131106/cb4d6eb0/attachment.pgp>


More information about the Freeradius-Users mailing list