3.0.2: rlm_sql_null duplicating its statements

[Stefan Winter]

Hi,

there was no real "it's fixed" conclusion yesterday, was there?

I.e. could you point me to a commit to cherry-pick?

If not... here's a really simple and stupid suggestion (from someone who
didn't write C/C++ since a decade!):

> 	if ((rad_lockfd(fd, len + 2) < 0) || (write(fd, query, len) < 0) || (write(fd, ";\n", 2) < 0)) {

Since the main problem is that the ; and queries somehow get mixed -
would not a *single* write that combines the two write()s fix that? I'm
thinking of:

... || (write(fd, query + ";\n", len + 2) < 0) ...

Maybe I'm too naive ...

Stefan

-- 
Stefan WINTER
Ingenieur de Recherche
Fondation RESTENA - Réseau Téléinformatique de l'Education Nationale et
de la Recherche
6, rue Richard Coudenhove-Kalergi
L-1359 Luxembourg

Tel: +352 424409 1
Fax: +352 422473

PGP key updated to 4096 Bit RSA - I will encrypt all mails if the
recipient's key is known to me

http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xC0DE6A358A39DC66
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0x8A39DC66.asc
Type: application/pgp-keys
Size: 3243 bytes
Desc: not available
URL: <http://lists.freeradius.org/mailman/private/freeradius-users/attachments/20140408/dcf9e927/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freeradius.org/mailman/private/freeradius-users/attachments/20140408/dcf9e927/attachment.pgp>