Trouble getting ldaps to work

[Arran Cudbard-Bell]

On 13 Jan 2014, at 10:33, Alberto Martínez <alberto_martinez at deusto.es> wrote:

> Hi Arran.
> 
> >> It works. It just doesn't work as expected.
> 
> Ug. sizeof(bool) != sizeof(int) on your system.
> 
> Ok, pushed a fix, nothing to do with ldap. Check config global was being declared incorrectly in some files.
> 
> Thanks for the bug report.
> 
> I have tried the master git branch and now it works nicely :)

Thanks for confirming.

I checked, and that's the last bool external.

Globals are generally bad in a largish code base, but the problem gets much worse when declarations for them are sprinkled around multiple files.

Interestingly non of the static analysis tools picked this up.

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS Development Team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 881 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20140113/c2760d4e/attachment.pgp>