Wrong ID for IWF-Session in RFC 4679 dictionary

[Guillaume Nault]

Hi,

The IWF-Session attribute is set to 252 in dictionary.rfc4679, while
the Vendor-Type defined by RFC 4679 is 254
(https://tools.ietf.org/html/rfc4679#section-3.3.18). This is consistent
with the value used by the TR-101 specification (section 3.9.6 in
http://www.broadband-forum.org/technical/download/TR-101.pdf).

The following diff would fix the issue:
--- a/share/dictionary.rfc4679
+++ b/share/dictionary.rfc4679
@@ -58,6 +58,6 @@
 #  If this attribute exists, it means that IFW has been performed
 #  for the subscribers session.
 #
-ATTRIBUTE	IWF-Session				252	octets # 0
+ATTRIBUTE	IWF-Session				254	octets # 0
 
 END-VENDOR ADSL-Forum

Should I send a regular patch to fix this typo ?

Regards,

Guillaume
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20140117/14454d91/attachment.pgp>