VSA processing in avpair.c in the client : (unknown Vendor-Id)

[bmoyni01 at vodafone.ie]

Hi.

I'm getting the following log:

rc_avpair_gen: received VSA attribute with unknown Vendor-Id 311

Just looking at rc_avpair_gen() in avpair.c

/* VSA */
		if (attribute == PW_VENDOR_SPECIFIC) {
			if (attrlen < 4) {
				rc_log(LOG_ERR, "rc_avpair_gen: received VSA "
				    "attribute with invalid length");
				goto shithappens;
			}
			memcpy(&lvalue, ptr, 4);
			vendorpec = ntohl(lvalue);
			if (rc_dict_getvend(rh, vendorpec) == NULL) {
				/* Warn and skip over the unknown VSA */
				rc_log(LOG_WARNING, "rc_avpair_gen: received VSA "
				    "attribute with unknown Vendor-Id %d", vendorpec);
				return pair;
			}
			/* Process recursively */
			return rc_avpair_gen(rh, pair, ptr + 4, attrlen - 4,
			    vendorpec);
		}

The comment would suggest that we just log and move on, but there is a 
return
and process recursively leg of code is not given a chance.

So a couple of questions:

1/ is the return valid
2/ how can the the client be enabled to understand the Vendor-Id 311 ( 
MSFT)


Thanks. 






I'm using Vodafone Mail - to get your free mobile email account go to http://www.vodafone.ie
Use of Vodafone Mail is subject to Terms and Conditions  http://www.vodafone.ie/terms/website