operator = not working

Arran Cudbard-Bell a.cudbardb at freeradius.org
Thu Feb 11 03:43:22 CET 2016


> On 10 Feb 2016, at 16:28, Alan Batie <alan at peak.org> wrote:
> 
> According to http://wiki.freeradius.org/config/Operators :

Pushed a fix.

I think some of the operator constants were re-ordered by me many years ago before I realised there were checks like:

	if ((operator < T_OP_ADD) ||
	    (operator > T_OP_CMP_EQ)) {

Not necessarily wrong, but not the most robust way of checking things...

	if (!fr_assignment_op[op] && !fr_equality_op[op]) {

Is much more robust/readable :)

-Arran

Arran Cudbard-Bell <a.cudbardb at freeradius.org>
FreeRADIUS development team

FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 872 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freeradius.org/pipermail/freeradius-users/attachments/20160210/4a91023f/attachment.sig>


More information about the Freeradius-Users mailing list