Segfault at src/lib/misc.c:1193 in 3.0.4 (3.0.11 looks very similar)

[Alan DeKok]

On Sep 26, 2016, at 4:13 PM, Mike Ely <me at mikeely.org> wrote:
> 
> The configs are complex and have had many hands on them over a long period of time. I am attempting to migrate these configs (some of them set by people who are no longer present where I work) over from a working 2.x system that proxies numerous devices. In order to get the migrated configs to work I had to change the user and group stanzas to within a security{} block and also get rid of calls to the no longer used rlm_acct_unique module.

  The recommendation is to create a new configuration instead of migrating an old one.  The configurations are similar, but not identical.

> The configurations would require a fair amount of redaction to share publicly, which is why I asked the more general question of where to look within them. Insulting anyone was the nowhere in my mind. I'm trying to figure out an unexpected crash, that's all.

  Asking leading questions is unpleasant and unnecessary.

> Here's the backtrace:
> #0  fr_ipaddr_cmp (a=0x20, b=0x7f3965a30510) at src/lib/misc.c:1193 
> #1  0x00007f3967740426 in check_for_realm (instance=<optimized out>, request=0x7f396f3cda40, returnrealm=0x7f3965a30580)
>    at src/modules/rlm_realm/rlm_realm.c:276 
> #2  0x00007f396774052d in mod_preacct (instance=<optimized out>, request=0x7f396f3cda40) at src/modules/rlm_realm/rlm_realm.c:399
> #3  0x00007f396d5f3109 in call_modsingle (request=0x7f396f3cda40, sp=0x7f396f3b3720, component=RLM_COMPONENT_PREACCT)
>    at src/main/modcall.c:318 

  Hmm.. you have a fail-over pool with a mix of real home servers, and local ones (i.e. virtual servers).  This is generally not recommended, but is allowed.

  I've pushed a fix.

  Alan DeKok.