Control sub-TLV attributes order in rest module

[Alan DeKok]

> On Sep 11, 2017, at 10:44 PM, Arran Cudbard-Bell <a.cudbardb at freeradius.org> wrote:
> 
> 
>> On 11 Sep 2017, at 18:02, Avner Elizarov <avnerelizarov at gmail.com> wrote:
>> 
>> The documentation is quite lacking
> 
> That's simply not true.

  In this case, the usual pattern has been followed:

Q: I'm trying to do stuff.. what do I do?
A: here's some general guidelines

Q: it doesn't work, I tried to do more stuff, it doesn't work!
A: here's some more help

Q: I tried more stuff, and it still doesn't work!
A: perhaps you could say WHAT you were doing, and WHAT happened?

Q: you guys suck!  Your documentation sucks!

  Uh... no.  It was pretty clear from the second email that the guy was not reading the docs, and paying little attention to how the system works, and not really trying any tests to see what the server does.  Just "You guys suck!"

>> for the rest module, and contains
>> features not yet published in version 3 (such as sub attributes).
> 
> Where‽ I don't see anything that describes sub-attributes.

  He wants to use sub attributes, and thinks they're magic.  Instead of reading the docs and examples, or *trying* different packets, he's upset because the documentation doesn't match his misconception of how the server works.

  *Nothing* in the documentation talks about sub-attributes.  Therefore his conclusion is that v3 doesn't support them, despite thousands of ATTRIBUTE entries in the dictionaries which are, in fact, sub-attributes.

  To fix that misconception, all he had to do was a simple test of sending / receiving sub-attributes... via something *other* than the rest module.  But he wanted to use the REST module... so why would he do tests with other parts of the server to see how it works?

> Post examples of what you tried and debug output.

  I suspect that won't happen.

>> When
>> sending several instances of the same sub attribute in the json message
>> only the last one was parsed by the rest module.
> 
> Use the '+=' operator, the documentation clearly says the operator defaults to ':='. Fine... fine that bit isn't super clear. I'll edit the docs to add a note for that.

  The use of "operator" is clear, and is documented extensively all through the rest of the server.

  Alan DeKok.