TXID mismatch between DHCP Request-Offer (devel version)

[Alan DeKok]

> On Nov 22, 2018, at 8:54 AM, Chinnapaiyan, Nagamani <Nagamani.Chinnapaiyan at viasat.com> wrote:
> 
> It works after changing the code in my local repo... Thanks... We are storing TXID as it is(without ntohl). But while sending we are doing htonl. Corrected that also.

  OK.  I'll add that fix.

> +//Decode message type from the option.
> +VALUE_PAIR *message_type = NULL;
> +message_type = fr_pair_find_by_da(head, attr_dhcp_message_type, TAG_ANY);
> +if(message_type) {
> +packet->code = message_type->vp_uint8;
> +}

  That's not really necessary.  The packet code is already being set by proto_dhcpv4.

  I'll push some more cleanups.

  Alan DeKok.