LDAP-UserDN is not unique per ldap module instance (auth problem when multiple ldap module instances used)

[Kostas Zorbadelos]

On Παρ, Σεπ 14 2018 at 08:32:21 πμ, Alan DeKok <aland at deployingradius.com> wrote:

Hello Alan and all,

unfortunately I bumped into a side issue when trying to test this. My
dev system is old, CentOS 6.10

[root at devradius ~]# gcc --version
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-23)
Copyright (C) 2010 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Building branch 3.0.x fails with the following error:

CC src/lib/atomic_queue.c
src/lib/atomic_queue.c:29:22: error: stdalign.h: No such file or directory
src/lib/atomic_queue.c:42: error: expected specifier-qualifier-list before ‘alignas’
src/lib/atomic_queue.c:47: error: expected specifier-qualifier-list before ‘alignas’
src/lib/atomic_queue.c: In function ‘fr_atomic_queue_create’:
src/lib/atomic_queue.c:78: error: ‘fr_atomic_queue_t’ has no member named ‘entry’
src/lib/atomic_queue.c:90: error: ‘fr_atomic_queue_t’ has no member named ‘entry’
src/lib/atomic_queue.c:91: error: ‘fr_atomic_queue_t’ has no member named ‘entry’
src/lib/atomic_queue.c:94: error: ‘fr_atomic_queue_t’ has no member named ‘size’
src/lib/atomic_queue.c:100: error: ‘fr_atomic_queue_t’ has no member named ‘head’
src/lib/atomic_queue.c:101: error: ‘fr_atomic_queue_t’ has no member named ‘tail’
src/lib/atomic_queue.c: In function ‘fr_atomic_queue_push’:
...

Is there a way to overcome this (without upgrading gcc)?
I think this will be an issue affecting 3.0.18 release. Would you like
me to report it in a github issue?

Tomorrow I will test in a newer CentOS 7 system to test the actual ldap
module fix.

Regards,
Kostas

> On Sep 14, 2018, at 8:04 AM, Kostas Zorbadelos <kzorba at otenet.gr> wrote:
>> Is this by design? I would expect each module instance to have its own
>> LDAP-UserDN and use that when used in authentication. Am I missing
>> something, or is this something worth of raising a github issue?
>
>   I've pushed a fix:  https://github.com/FreeRADIUS/freeradius-server/commit/803cbea51b17620f467dd1c6d19172e892cd164b
>
>   Please verify it and get back to me.  We should be releasing 3.0.18 soon.
>
>   Alan DeKok.
>

-- 
Kostas Zorbadelos	http://gr.linkedin.com/in/kzorba