sqlippool on 3.0.18

[Alan DeKok]

On Feb 27, 2019, at 12:44 AM, Nathan Ward <lists+freeradius at daork.net> wrote:
> 
> Wading in to this one now - not sure if this is a bug or if it’s known/fixed so posting here in the hope someone else has had this and looked in to it. If not, I’m learning a lot, so, that’s good. Will post more when I have it.

  I've pulled over your fixes from the GitHub pull request.

> Etc. so I’m thinking that commit didn’t take sqlippool in to account.

  Yes.  

> I notice there’s a new function, sql_escape_for_xlat_func, which gets a connection from the pool then releases it, but I’m not sure that’s right for this situation in sqlippool - we’re doing these xlats in the middle of a transaction, so we should have a handle already?

  Yes.

  We may need to release 3.0.19 soon.  <sigh>

  The underlying issue is that we simply can't test everything in the server.  We rely on the community to supply good patches, and to test those patches before an official release.

  Alan DeKok.