Route through post-proxy not working when no live home servers are available - (3.0.20)

[Alan DeKok]

On Apr 15, 2020, at 12:36 PM, João Vitor Arruda <joao.arruda at gmail.com> wrote:
> 
> Hello there I would like to request your help to see why we are facing
> this issue that was supposedly fixed in
> https://github.com/FreeRADIUS/freeradius-server/pull/2072

  OK...

> We have a server configured to proxy to an upstream server and the
> "post-proxy" configured with "Post-Proxy-Type Fail-Authentication"
> (tested with "Post-Proxy-Type Fail" too) to not respond.

  OK.

> When the upstream server does not reply (either before or after
> starting the zombie period) the post-proxy section is invoked and
> works as expected as you can see in the log bellow (some lines were
> suppressed):

  That's good.

> But when the upstream server is marked as DEAD the post-proxy section
> is never invoked as you can see in the log bellow (some lines were
> suppressed):

  Hmm... the code in line 3085 of src/main/process.c should likely be

	return -1;

instead of

	return 1;

  That's should fix it.

  i.e  the "return" in the middle here:

	home = home_server_ldb(realmname, pool, request);

	if (!home) {
		REDEBUG2("Failed to find live home server: Cancelling proxy");
		return -1;
	}

do_home:
	home_server_update_request(home, request);


  Please try that.  If it works, I'll push a fix.

  Alan DeKok.