3.0.23 does not compile with --enable-werror

[Alan DeKok]

On Jun 14, 2021, at 5:19 AM, Daniel Finger <daniel.finger at ewetel.de> wrote:
> 
> I try to compile Version 3.0.23 with
> ./configure --prefix=/opt/radius/software/freeradius-server --enable-strict-dependencies     --with-raddbdir=/etc/raddb --enable-werror     --with-gnu-ld     --disable-developer --with-threads     --with-thread-pool     --with-dhcp=yes --with-jsonc-include-dir=/usr/include/json --with-rlm-sql_mysql-include-dir=/usr/include/mysql --with-rlm-sql_mysql-lib-dir=/usr/lib64/mysql --with-rlm-ldap-include-dir=/usr/local/openldap/include --with-rlm-ldap-lib-dir=/usr/local/openldap/lib64 --with-rlm_cache_memcached     --with-rlm_redis --enable-reproducible-builds     --without-rlm_yubikey --without-libwbclient     --without-rlm_eap_ikev2 --without-rlm_eap_tnc --without-rlm_pam --without-rlm_sql_iodbc --without-rlm_sql_postgresql --without-rlm_sql_oracle --without-rlm_sql_unixodbc     --without-rlm_sql_freetds --without-rlm_rediswho
> 
> but this produces:
> 
> CC src/modules/rlm_eap/rlm_eap.c
> src/modules/rlm_eap/rlm_eap.c: In function 'mod_instantiate':
> src/modules/rlm_eap/rlm_eap.c:146:4: error: too many arguments for format [-Werror=format-extra-args]
>     WARN("rlm_eap (%s): Ignoring EAP method 'leap', because it is no longer supported",
>     ^
> 
> 
> Introduced in: https://github.com/FreeRADIUS/freeradius-server/commit/d9582d233bb0b2ba14d4c0f1350949fe7dec472e
> 
> Seems the same Error is in line 187, but I assume most people have SSL-Libraries installed.

  Thanks.  I'll push a fix.  I think -Wformat-extra-args is new, so we don't enable it by default.

  We also don't enable -Werror by default, because different compilers have different ideas of warnings.  So adding -Werror default means that it won't build on most peoples systems.

  Alan DeKok.