Issues with bug#235

[Kevin Bonner]

I've been working to merge our auth and acct configs into one (previously we 
ran each on separate servers), and I am hitting bug#235.  I snagged the 
rlm_sql.c changes from CVS and rebuilt 1.1.2.

My sql.conf config looks like:
sql sqlX {
  deletestalesessions = no
  simul_count_query = "select count(*) from radacct where ..."
  simul_verify_query = "select ... from radacct where ..."
}

Looking at rlm_sql.c (near line 1386 in the CVS head), we see:
    if (inst->config->deletestalesessions == FALSE ||
        inst->config->simul_verify_query[0] == '\0') {
        sql_release_socket(inst, sqlsocket);
        return RLM_MODULE_OK;
    }

Since the deletestalesessions check evaluates to true, the code never enters 
the section to verify any of the sessions found.  This changes the behavior 
from all FreeRADIUS releases.

Should this be fixed, is this the desired result, or am I forgetting something 
simple?

Kevin Bonner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.freeradius.org/pipermail/freeradius-devel/attachments/20060703/91bd8c1b/attachment.pgp>