rlm_sql_oracle: OCI_COMMIT_ON_SUCCESS

17 Jul 2017

      Hi guys,

rlm_sql/drivers/rlm_sql_oracle/rlm_sql_oracle.c:

    status = OCIStmtExecute(conn->ctx, conn->query, conn->error, 1, 0,
                            NULL, NULL, OCI_COMMIT_ON_SUCCESS);

Any reason for having OCI_COMMIT_ON_SUCCESS in OCIStmtExecute() call?

The problem is that any module (rlm_sqlippool is a good candidate)
relying on rlm_sql and using the concept of database transactions will
have no chance to rollback, neither it can provide any guarantee for
data consistency.

Kind regards,

George Chelidze