26 Sep
2012
26 Sep
'12
5:38 a.m.
Phil Mayers wrote:
The reason I ask is that rad_authenticate already calls the "authorize {}" and "authenticate {}" blocks, so symmetry would seem to suggest it call the "post-auth {}" block too.
That might make sense, too. There are many ways of doing things. Some I have strong opinions about. Some I don't.
The other thing is that this change moves the execution context for the vast majority of post-auth calls (since most auths succeed). That might not matter, although I'm not sure about which thread request_finish executes in, or if it matters.
request_finish() should run in the same thread as rad_authenticate() Alan DeKok.