19 Jan
2014
19 Jan
'14
5:06 p.m.
On 01/19/2014 03:09 PM, John Dennis wrote:
On 01/19/2014 02:21 PM, Alan DeKok wrote:
The patch affects *all* attributes made via paircreate().
I'll take a pass through the modules to remove code which sets the vp length manually. It should not be necessary for ipv4 attributes, etc.
commit 0b48c180 for rlm_sqlipool is one that should be removed, it would break if and when ipv6 is supported.
While you're at it could you also fix the warning messages in rad_encode() (radius.c around line 1850) so they're emitted. Maybe they should be DEBUG statements instead of fr_strerror_printf() or maybe fix fr_strerror_printf(), either way it should show up when running in debug -X mode. -- John