Matthew Newton wrote:
Basic tests seem OK - builds as a debian package on wheezy/amd64, and works. Haven't exercised much else though. There's a warning about potentially unused variable compare in src/lib/valuepair.c:2651, but it can't happen looking at the code. Maybe needs a compare=compare to silence it?
Weird. Arran saw that, too. Different compilers produce different warning messages. And from what I can tell, that warning message isn't true. Coverity doesn't complain, and it does more in-depth checks than gcc.
Seems reasonable - agree that User-Password should continue to show. Need enough to show that people have the wrong shared secret (corrupt user-password) or the user-password is wrong, which I think this will do. I don't think that it's a good thing to start mangling or blanking out attributes in debug output.
Exactly.
If anyone objects, please let me know.
Looks OK as is now. Just need to stop people posting -Xx by default, which a reasonable number still seem to do :(
Yes. It's hard to get people to follow the documentation. Alan DeKok.