On Thursday 14 September 2006 20:46, Alan DeKok wrote:
Fixed bug id #390 Removed pairfree and Updated to use pairmove.
No, this is wrong. "pairmove" uses the operators to determine which attributes to move, and which to leave behind. Since Perl can update all of the attributes via it's own logic, it does not need the operators. The operators are ONLY for the "users" file, which is a hack.
In addition, pairmove() MIGHT leave VALUE_PAIR's in the source list. The change you made didn't free them, so there is a memory leak in the code.
I'm going to revert this change, and commit a different fix for bug #390.
The "Operator" code added in revision 1.38 is not needed. Again, the *only* purpose of the operator in the VALUE_PAIR is a hack, to make the "users" file work. Since the Perl script can make it's own decisions about which attributes to over-write and why, it's completey unnecessary to support operators here. All of the code dealing with "Operator" in rlm_perl.c should be deleted.
The attributes used in rlm_perl should just be names and values, without operators. I'll be updating the module to remove the "Operator" stuff. It's confusing, and not necessary.
Ok I am agree with this. -- Best Regards, Boian Jordanov SNE Orbitel - Next Generation Telecom tel. +359 2 4004 723 tel. +359 2 4004 002