Possible bug in logging duplicate requests

15 Mar 2011

      Hello!

I've found that when duplicate request found it is logged with
(probably) wrong printf pattern:

src/main/event.c line 2574:
------------------
        radlog(L_ERR, "Discarding duplicate request from "
               "client %s port %d - ID: %d due to unfinished request %u",
               client->shortname,
               request->packet->src_port,request->packet->id,
               request->number);
        break;
-----------------

Due to 'ID: %d' I'm getting negative IDs in log:

Tue Mar 15 11:46:57 2011 : Error: Discarding duplicate request from
client dhcp port 67 - ID: -2021971096 due to unfinished request 977

I think it should be changed to '%u'.

-- 
Alexandr Kovalenko
http://uafug.org.ua/