On 20 Jun 2014, at 11:17, Arran Cudbard-Bell <a.cudbardb@freeradius.org> wrote:
On 20 Jun 2014, at 10:56, Phil Mayers <p.mayers@imperial.ac.uk> wrote:
Hmm assuming nothing else is talloc'ed off the parent of handler that is, or freeing handler itself is racey...
That's now fixed too. I think. The memory associated with the handler is now freed within the destructor for the handler, which synchronises the frees using the same mutex. Hopefully that's OK.
https://github.com/FreeRADIUS/freeradius-server/commit/f74b0fe85f171faf5c144...
If it explodes I guess we'll need to figure out another solution.
Confirmed lack of explodyness. I also fixed some other explicit frees of VPs which were associated with the EAP specific opaque data. -Arran Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2