commit b74f503ae851e1448119d972bf499cf1bd97dc04 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 16:10:51 2008 +0100 Die if we failed to allocate memory Closes Coverity #63 We don't need to check for "cs->section_tree" twice. Just check for it once, and if we can't allocate it, die. Checking a second time is pointless. Files changed: src/main/conffile.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) ====================================================================== commit 0941ba865da2a3a0bdc3355d2f5d1c1847e3f468 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 16:08:09 2008 +0100 "name" cannot be NULL If it's NULL, we can't use it at all. The previous code used it if it was NULL... Closes Coverity #64 Files changed: src/main/conffile.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) ====================================================================== commit 7cc91bd8c1f4bbf07cfa3fd7f928ad72b7e36e53 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 16:02:15 2008 +0100 log_file may be NULL Closes Coverity #65 Files changed: src/main/log.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 63b91380d6589b016cbf06ff61e63aa0d970f29e Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 15:54:01 2008 +0100 Request may be NULL Closes Coverity #66 Files changed: src/main/log.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 289fa1f9aa6902f5e2ef693bb8486164c27c4565 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 14:44:25 2008 +0100 Set "found" to first server. Closes Coverity #67 Files changed: src/main/realms.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) ====================================================================== commit c862da5788218a9ebbfa8858f87bfd7da9627caa Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 14:40:00 2008 +0100 secret is NULL for LOCAL realms. Fixes Coverity #68 Files changed: src/main/realms.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 751a09fc7c980940d4776aa8576dcc31c2f54c51 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 14:36:54 2008 +0100 virtual_server can't be NULL If we see "virtual_server = " in a home_server_pool, it's an error. If you want to refer to the default virtual server, don't include a virtual_server configuration entry. Files changed: src/main/realms.c | 9 ++------- 1 files changed, 2 insertions(+), 7 deletions(-) ====================================================================== commit d4ed81e9dedff42ec96d1191ec4cb5e8070af511 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 13:54:35 2008 +0100 One more check for NULL. Closes Coverity #80. Not that we think it's likely... Files changed: src/modules/frs_detail/frs_detail.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit c09ee1fcde0c9fc2df1d79deb02a1cba83d02822 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 13:19:29 2008 +0100 More memory initialization Closes Coverity #83 Files changed: src/lib/misc.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) ====================================================================== commit a6e4ea36bc10ec99d1e85803ef2423179d6a3821 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 10:50:29 2008 +0100 free structure on error. Closes Coverity #76 Files changed: src/main/listen.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) ====================================================================== commit 232719a6f7a3744dae1ddd0972f2895ac61c2dd1 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 10:47:31 2008 +0100 Free fake on unknown packet. This fixes Coverity #77. Files changed: src/main/event.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) ====================================================================== commit 42cf73caa0e904e045c579f4da9a330d222e4251 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 10:45:49 2008 +0100 Don't allocate structure twice. This fixes Coverity #78 Files changed: src/modules/rlm_policy/parse.c | 12 ++++++++---- 1 files changed, 8 insertions(+), 4 deletions(-) ====================================================================== commit 0493015e4194fcf94ebeffd8466ca323d859a018 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 10:40:24 2008 +0100 Ensure there's room for a trailing 0 This address Coverity #70. I don't think it will ever happen due to the way the strings are being handled, but it never hurts to be safe... Files changed: src/main/xlat.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ====================================================================== commit e1605352ffddc90049fb0d1016508640208f547d Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 10:37:21 2008 +0100 Assert that comp < count, not <= count This fixes Coverity #72 Files changed: src/main/modules.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) ====================================================================== commit 0290d7c35d43632af84d3c2706656b4f46506f11 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 10:33:41 2008 +0100 De-reference ptr after checking it. This fixes Coverity #79 Files changed: src/main/evaluate.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) ====================================================================== commit c608d0214d614060dd7eb3bc1943daa4c2767245 Author: Alan T. DeKok <aland@freeradius.org> Date: Mon Dec 1 10:27:24 2008 +0100 Initialize stack.start[0]. This should address Coverity issue #104 Files changed: src/main/modcall.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) ====================================================================== commit 45baf9c4c977e791851291465c8213f978b88b07 Author: Alan T. DeKok <aland@freeradius.org> Date: Thu Nov 27 16:14:23 2008 +0100 Include socket code in modules for static builds Files changed: src/main/Makefile.in | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) ======================================================================