On 18 Jun 2014, at 11:24, Phil Mayers <p.mayers@IMPERIAL.AC.UK> wrote:
On 17/06/14 23:57, Arran Cudbard-Bell wrote:
OK. Fixed the obvious places which might have triggered that. The code in tmpl2str for printing literals was not threadsafe and that's been fixed too.
Ok, runs now. Will set it going and see if it dies after time.
n.b. there are still a couple of valgrind-reported leaks with "-m" in the clients and another bit I don't understand, but otherwise clean valgrind report:
2,784 (168 direct, 2,616 indirect) bytes in 1 blocks ar at 0x4A069EE: malloc (vg_replace_malloc.c:270) by 0x36AD405228: _talloc_zero (talloc.c:560) by 0x4E5DECA: rbtree_create (rbtree.c:116) by 0x40E69B: client_add (client.c:222) by 0x41002E: clients_parse_section (client.c:889) by 0x41424E: common_socket_parse (listen.c:1222) by 0x41CB30: listen_parse (listen.c:2863) by 0x41D22C: listen_init (listen.c:3104) by 0x43CFEA: radius_event_start (process.c:4760) by 0x429EDF: main (radiusd.c:462)
Ok that should now be fixed.
26,637 bytes in 13 blocks are definitely lost in loss r at 0x4A069EE: malloc (vg_replace_malloc.c:270) by 0x4E50012: fr_strerror_printf (log.c:68) by 0x4E646F6: pairparsevalue (valuepair.c:1426) by 0x4E6553D: pairmake (valuepair.c:1886) by 0x435141: request_finish (process.c:1342) by 0x4355F7: request_running (process.c:1526) by 0x430D70: request_handler_thread (threads.c:685) by 0x379E4079D0: start_thread (pthread_create.c:301) by 0x379DCE8B7C: clone (clone.S:115)
Magic Thread Local Storage stuff, don't worry about it. Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS Development Team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2