On Tue 02 Oct 2007, Gabriel wrote:
I am currently working on the rlm_sqlippool module to work with ms sql. I believe I discovered a bug in the sqlippool_query1 function and was able to fix it.
Somehow the function uses the return of rlm_sql_fetch_row as a strlen of the result. It then uses this return "r" to do a strncpy to the return string value of this rlm_sqlippool. The problem is, it seems that rlm_sql_fetch_row returns 0 in the case of ms sql and then the strncpy fails.
How do I go about submitting a patch about this problem?
If you are doing any work with rlm_sqlippool please make sure you are working with the latest cvs HEAD code. Please test any patches you make against a known working DB (Either Postgresql or MySQL) as well, and then send them to the list for review. Cheers -- Peter Nixon http://peternixon.net/