On Tue, 2013-06-11 at 11:50 -0400, Alan DeKok wrote:
Stelian Ionescu wrote:
No, it's a regression. On 2.* commas and apostrophes part of the literal query as embedded in dialup.conf didn't get escaped, only the various expansions; but now the whole query gets escaped .
It's a bug fix.
In 2.x, the '?' character wasn't listed in "safe-characters". Yet it wasn't escaped. That's wrong.
The expansion functionality was re-written for v3. It's now less code, with better error messages, and fewer weird corner cases. As a side effect, the "safe-characters" is now processed correctly. Previously, it wasn't.
The "safe-characters" list is editable for a reason. If '.' and '?' should be listed by default, we can go fix that. But the functionality WILL NOT be reverted. The old code was wrong.
I'm not referring to '?', but to the fact that parts of the query are being escaped which is wrong because it produces incorrect queries by escaping commas and apostrophes. -- Stelian Ionescu a.k.a. fe[nl]ix Quidquid latine dictum sit, altum videtur. http://common-lisp.net/project/iolib