On Fri 01 Sep 2006 01:51, Alan DeKok wrote:
Peter Nixon <listuser@peternixon.net> wrote:
Forgive me if this has been asked before, but shouldn't the sql_log module use the same SQL queries from as the normal sql module? Why does it have it's own set of queries in radiusd.conf?
Probably, and it was easier that way...
As far as I can tell it should simply ignore connection info and non accounting queries otherwise do exactly the same thing!
Yes.
The other thing is that the SQL module should be updated to auto-discover more queries like rlm_sql_log, rather than having them hard-coded. This means that any new accounting status type can be supported by simply adding the queries.
Can't we just make it a driver for rlm_sql? -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc