28 Feb
2012
28 Feb
'12
4:15 a.m.
Matthew Newton wrote:
I've been a bit busy with other things, but have now got around to doing this. There's a branch at the following URL with a set of patches to do it.
OK. I added some comments, mostly minor.
I did this by caching the result in tls_server_conf_parse - if it's passed the same CONF_SECTION as the previous time, it returns the same conf pointer. As the EAP sections are pretty much always going to be called consecutively, this saves re-parsing each time.
It was about 5 lines of code - dunno if it was what you were thinking or not ;-)
It's not. Static variables are generally bad. My comments on github suggest a better way. Alan DeKok.