11 Feb
2015
11 Feb
'15
10:54 a.m.
On Feb 11, 2015, at 10:35 AM, Phil Mayers <p.mayers@imperial.ac.uk> wrote:
Cool. I was going to suggest a talloc_pool() for REQUEST's a while back but never got round to doing any measurement.
It’s noticeably faster. While we were on that work, we made a few other changes which improved other areas.
I guess the pool size could be a global but it's almost certainly unnecessary - most requests won't be around for long enough for it to matter.
The talloc documentation says to *not* use a pool per request. But their use-case is a bit different, I think. It works, it’s faster, and the code changes are small. Alan DeKok.