Automatic report from sources (radiusd) between 16.12.2007 - 17.12.2007 GMT
CVS log entries from 16.12.2007 (Sun) 09:00:00 - 17.12.2007 (Mon) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_unixodbc/sql_unixodbc.c; Revisions: 1.23 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c; Revisions: 1.58 File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c; Revisions: 1.50 File: radiusd/src/modules/rlm_passwd/rlm_passwd.c; Revisions: 1.37 File: radiusd/src/modules/rlm_sql/rlm_sql.h; Revisions: 1.41 File: radiusd/src/modules/rlm_sql/sql.c; Revisions: 1.96 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_oracle/sql_oracle.c; Revisions: 1.44 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_mysql/sql_mysql.c; Revisions: 1.28 File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revisions: 1.9 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_sybase/sql_sybase.c; Revisions: 1.14 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_firebird.c; Revisions: 1.3 File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revisions: 1.80 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_iodbc/sql_iodbc.c; Revisions: 1.25 File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revisions: 1.178 ===================================================== Combined list of identical log entries ===================================================== Description: Added more 'const' Modified files: File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revision: 1.80; Date: 2007/12/17 07:50:21; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revision: 1.178; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+17 -17) File: radiusd/src/modules/rlm_sql/rlm_sql.h; Revision: 1.41; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_sql/sql.c; Revision: 1.96; Date: 2007/12/17 07:39:31; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_firebird.c; Revision: 1.3; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_iodbc/sql_iodbc.c; Revision: 1.25; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_mysql/sql_mysql.c; Revision: 1.28; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_oracle/sql_oracle.c; Revision: 1.44; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c; Revision: 1.58; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_sybase/sql_sybase.c; Revision: 1.14; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_unixodbc/sql_unixodbc.c; Revision: 1.23; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+3 -3) ------------------------------- Description: Fix compiler warnings Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revision: 1.9; Date: 2007/12/17 07:38:37; Author: aland; Lines: (+9 -9) File: radiusd/src/modules/rlm_passwd/rlm_passwd.c; Revision: 1.37; Date: 2007/12/17 07:49:42; Author: aland; Lines: (+4 -4) ===================================================== Log entries ===================================================== Description: Require client cert for TLS Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c; Revision: 1.50; Date: 2007/12/17 06:45:34; Author: aland; Lines: (+2 -9) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c Revisions: 1.50 Authors: aland (+2 -9) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c Revisions: 1.9 Authors: aland (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_passwd/rlm_passwd.c Revisions: 1.37 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c Revisions: 1.80 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_firebird.c Revisions: 1.3 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_iodbc/sql_iodbc.c Revisions: 1.25 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_mysql/sql_mysql.c Revisions: 1.28 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_oracle/sql_oracle.c Revisions: 1.44 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c Revisions: 1.58 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_sybase/sql_sybase.c Revisions: 1.14 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_unixodbc/sql_unixodbc.c Revisions: 1.23 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.c Revisions: 1.178 Authors: aland (+17 -17) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.h Revisions: 1.41 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_sql/sql.c Revisions: 1.96 Authors: aland (+3 -3) -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl
Automatic cvs log generator wrote:
CVS log entries from 16.12.2007 (Sun) 09:00:00 - 17.12.2007 (Mon) 09:00:00 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_unixodbc/sql_unixodbc.c; Revisions: 1.23 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c; Revisions: 1.58 File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c; Revisions: 1.50 File: radiusd/src/modules/rlm_passwd/rlm_passwd.c; Revisions: 1.37 File: radiusd/src/modules/rlm_sql/rlm_sql.h; Revisions: 1.41 File: radiusd/src/modules/rlm_sql/sql.c; Revisions: 1.96 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_oracle/sql_oracle.c; Revisions: 1.44 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_mysql/sql_mysql.c; Revisions: 1.28 File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revisions: 1.9 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_sybase/sql_sybase.c; Revisions: 1.14 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_firebird.c; Revisions: 1.3 File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revisions: 1.80 File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_iodbc/sql_iodbc.c; Revisions: 1.25 File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revisions: 1.178
===================================================== Combined list of identical log entries ===================================================== Description: Added more 'const' Modified files: File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c; Revision: 1.80; Date: 2007/12/17 07:50:21; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/rlm_sql.c; Revision: 1.178; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+17 -17) File: radiusd/src/modules/rlm_sql/rlm_sql.h; Revision: 1.41; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_sql/sql.c; Revision: 1.96; Date: 2007/12/17 07:39:31; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_firebird.c; Revision: 1.3; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_iodbc/sql_iodbc.c; Revision: 1.25; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_mysql/sql_mysql.c; Revision: 1.28; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+3 -3) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_oracle/sql_oracle.c; Revision: 1.44; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c; Revision: 1.58; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+4 -4) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_sybase/sql_sybase.c; Revision: 1.14; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+2 -2) File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_unixodbc/sql_unixodbc.c; Revision: 1.23; Date: 2007/12/17 07:45:46; Author: aland; Lines: (+3 -3) ------------------------------- Description: Fix compiler warnings Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c; Revision: 1.9; Date: 2007/12/17 07:38:37; Author: aland; Lines: (+9 -9) File: radiusd/src/modules/rlm_passwd/rlm_passwd.c; Revision: 1.37; Date: 2007/12/17 07:49:42; Author: aland; Lines: (+4 -4) ===================================================== Log entries ===================================================== Description: Require client cert for TLS Modified files: File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c; Revision: 1.50; Date: 2007/12/17 06:45:34; Author: aland; Lines: (+2 -9) ===================================================== Summary of modified files ===================================================== File: radiusd/src/modules/rlm_eap/types/rlm_eap_tls/rlm_eap_tls.c Revisions: 1.50 Authors: aland (+2 -9) ------------------------------- File: radiusd/src/modules/rlm_eap/types/rlm_eap_tnc/rlm_eap_tnc.c Revisions: 1.9 Authors: aland (+9 -9) ------------------------------- File: radiusd/src/modules/rlm_passwd/rlm_passwd.c Revisions: 1.37 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_preprocess/rlm_preprocess.c Revisions: 1.80 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_firebird/sql_firebird.c Revisions: 1.3 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_iodbc/sql_iodbc.c Revisions: 1.25 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_mysql/sql_mysql.c Revisions: 1.28 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_oracle/sql_oracle.c Revisions: 1.44 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c Revisions: 1.58 Authors: aland (+4 -4) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_sybase/sql_sybase.c Revisions: 1.14 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_sql/drivers/rlm_sql_unixodbc/sql_unixodbc.c Revisions: 1.23 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.c Revisions: 1.178 Authors: aland (+17 -17) ------------------------------- File: radiusd/src/modules/rlm_sql/rlm_sql.h Revisions: 1.41 Authors: aland (+2 -2) ------------------------------- File: radiusd/src/modules/rlm_sql/sql.c Revisions: 1.96 Authors: aland (+3 -3)
gcc -g -O2 -D_LIBRADIUS -I/usr/local/src/freeradius-cvscurrent/src -c token.c -fPIC -DPIC -o .libs/token.o token.c:201: error: conflicting types for 'getword' /usr/local/src/freeradius-cvscurrent/src/freeradius-devel/token.h:74: error: previous declaration of 'getword' was here token.c:210: error: conflicting types for 'getbareword' /usr/local/src/freeradius-cvscurrent/src/freeradius-devel/token.h:75: error: previous declaration of 'getbareword' was here token.c:225: error: conflicting types for 'gettoken' /usr/local/src/freeradius-cvscurrent/src/freeradius-devel/token.h:76: error: previous declaration of 'gettoken' was here token.c:233: error: conflicting types for 'getstring' /usr/local/src/freeradius-cvscurrent/src/freeradius-devel/token.h:77: error: previous declaration of 'getstring' was here make[4]: *** [token.lo] Error 1 make[4]: Leaving directory `/usr/local/src/freeradius-cvscurrent/src/lib' make[3]: *** [common] Error 2 make[3]: Leaving directory `/usr/local/src/freeradius-cvscurrent/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/usr/local/src/freeradius-cvscurrent/src' make[1]: *** [common] Error 2 make[1]: Leaving directory `/usr/local/src/freeradius-cvscurrent' make: *** [all] Error 2 This is building on Ubuntu not OS X, was going to do some testing with valgrind myself, as it's hard to replicate our config without the underlying databases. -- Arran Cudbard-Bell (A.Cudbard-Bell@sussex.ac.uk) Authentication, Authorisation and Accounting Officer Infrastructure Services | ENG1 E1-1-08 University Of Sussex, Brighton EXT:01273 873900 | INT: 3900
Arran Cudbard-Bell wrote:
gcc -g -O2 -D_LIBRADIUS -I/usr/local/src/freeradius-cvscurrent/src -c token.c -fPIC -DPIC -o .libs/token.o token.c:201: error: conflicting types for 'getword' /usr/local/src/freeradius-cvscurrent/src/freeradius-devel/token.h:74: error: previous declaration of 'getword' was here
I failed to commit token.h. It's updated now, thanks. Alan DeKok.
Alan DeKok wrote:
Arran Cudbard-Bell wrote:
gcc -g -O2 -D_LIBRADIUS -I/usr/local/src/freeradius-cvscurrent/src -c token.c -fPIC -DPIC -o .libs/token.o token.c:201: error: conflicting types for 'getword' /usr/local/src/freeradius-cvscurrent/src/freeradius-devel/token.h:74: error: previous declaration of 'getword' was here
I failed to commit token.h. It's updated now, thanks.
Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
Yep that fixed it. Unfortunately I'm now getting seg faults on my 32bit Intel platform, ++[eap] returns noop ++? if ("%{Called-Station-Id}" =~ /^([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2,})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([-a-z0-9_.]*)?/i) expand: %{Called-Station-Id} -> ? Evaluating ("%{Called-Station-Id}" =~ /^([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2,})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([-a-z0-9_.]*)?/i) - ++? if ("%{Called-Station-Id}" =~ /^([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2,})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([-a-z0-9_.]*)?/i) -> FALS ++? if ("%{Calling-Station-Id}" =~ /([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2,})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})/i) expand: %{Calling-Station-Id} -> ? Evaluating ("%{Calling-Station-Id}" =~ /([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2,})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})/i) -> FALSE ++? if ("%{Calling-Station-Id}" =~ /([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2,})[-:]?([0-9a-f]{2})[-:]?([0-9a-f]{2})/i) -> FALSE ++? if ("%{NAS-Port-Id}" =~ /wl[0-9]*/) expand: %{NAS-Port-Id} -> ? Evaluating ("%{NAS-Port-Id}" =~ /wl[0-9]*/) -> FALSE ++? if ("%{NAS-Port-Id}" =~ /wl[0-9]*/) -> FALSE ++? if (("%{NAS-Port-Type}" == 'Wireless-802.11')||("%{NAS-Port-Type}" == 'Ethernet')) expand: %{NAS-Port-Type} -> Virtual ?? Evaluating ("%{NAS-Port-Type}" == 'Wireless-802.11') -> FALSE expand: %{NAS-Port-Type} -> Virtual ?? Evaluating ("%{NAS-Port-Type}" == 'Ethernet') -> FALSE ++? if (("%{NAS-Port-Type}" == 'Wireless-802.11')||("%{NAS-Port-Type}" == 'Ethernet')) -> FALSE ++? if ("%{NAS-IP-Address}" == '127.0.0.1') expand: %{NAS-IP-Address} -> 139.184.8.16 ? Evaluating ("%{NAS-IP-Address}" == '127.0.0.1') -> FALSE ++? if ("%{NAS-IP-Address}" == '127.0.0.1') -> FALSE expand: %{Client-Shortname} -> hp-e-its-dev8021x-sw1 ++[request] returns noop expand: /var/log/radiusd/%Y%m%d/auth-detail-%H:00 -> /var/log/radiusd/20071217/auth-detail-11:00 rlm_detail: /var/log/radiusd/%Y%m%d/auth-detail-%H:00 expands to /var/log/radiusd/20071217/auth-detail-11:00 expand: %t -> Mon Dec 17 11:21:33 2007 Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1212537152 (LWP 28517)] vp_prints (out=0xbfa72848 "", outlen=1024, vp=0xbfa74e1c) at print.c:389 389 if (!*name) { (gdb) bt #0 vp_prints (out=0xbfa72848 "", outlen=1024, vp=0xbfa74e1c) at print.c:389 #1 0xb7fb4838 in vp_print (fp=0x8465588, vp=0xbfa74e1c) at print.c:434 #2 0xb6fe8684 in do_detail (instance=0x8314bc8, request=0x8463920, packet=0x8463848, compat=0) at rlm_detail.c:402 #3 0x0805ba16 in ?? () #4 0x00000000 in ?? () -- Arran Cudbard-Bell (A.Cudbard-Bell@sussex.ac.uk) Authentication, Authorisation and Accounting Officer Infrastructure Services | ENG1 E1-1-08 University Of Sussex, Brighton EXT:01273 873900 | INT: 3900
Alan DeKok wrote:
Arran Cudbard-Bell wrote:
Unfortunately I'm now getting seg faults on my 32bit Intel platform,
Just committing a fix now...
Alan DeKok. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
Confirmed fixed, thanks. -- Arran Cudbard-Bell (A.Cudbard-Bell@sussex.ac.uk) Authentication, Authorisation and Accounting Officer Infrastructure Services | ENG1 E1-1-08 University Of Sussex, Brighton EXT:01273 873900 | INT: 3900
Correct me if I'm wrong... But I believe the "accounting_onoff_query" is to be executed by a rebooting nas, or other similiar situation, so that all accounts that are currently "online" or specifiically all accounting records that are open (START), are to be closed, only accounts pertaining to that specific nas.. Well that's how I read the conf file. If so, souldn't the query also update the AcctStatusType to "Stop" ?? I've looked over all the db examples, and they are pretty much the same, update the StopTime, SessionTime, TerminateCause, etc, but they don't update the StatusType... why? Duane
On Mon 17 Dec 2007, Duane Cox wrote:
Correct me if I'm wrong...
But I believe the "accounting_onoff_query" is to be executed by a rebooting nas, or other similiar situation, so that all accounts that are currently "online" or specifiically all accounting records that are open (START), are to be closed, only accounts pertaining to that specific nas.. Well that's how I read the conf file.
If so, souldn't the query also update the AcctStatusType to "Stop" ??
I've looked over all the db examples, and they are pretty much the same, update the StopTime, SessionTime, TerminateCause, etc, but they don't update the StatusType... why?
Possibly, although if there is a acctstoptime then the StatusType is not really necessary. Maybe the StatusType should be set to "off" or something similar to be explicit about how the record was closed... (These type of behaviours are not defined by RFCs so we try to come up with the most logical/usefull setup) Cheers -- Peter Nixon http://peternixon.net/
On 2007-Dec-17, at 15:33, Peter Nixon wrote:
On Mon 17 Dec 2007, Duane Cox wrote:
Correct me if I'm wrong...
But I believe the "accounting_onoff_query" is to be executed by a rebooting nas, or other similiar situation, so that all accounts that are currently "online" or specifiically all accounting records that are open (START), are to be closed, only accounts pertaining to that specific nas.. Well that's how I read the conf file.
If so, souldn't the query also update the AcctStatusType to "Stop" ??
I've looked over all the db examples, and they are pretty much the same, update the StopTime, SessionTime, TerminateCause, etc, but they don't update the StatusType... why?
Possibly, although if there is a acctstoptime then the StatusType is not really necessary. Maybe the StatusType should be set to "off" or something similar to be explicit about how the record was closed... (These type of behaviours are not defined by RFCs so we try to come up with the most logical/usefull setup)
Cheers
I agree with Peter on this one. I would set the Acct-Terminate-Cause to something like NAS-Reset. Setting the Acct-Status-Type to Stop would in fact be misrepresenting the facts. In practice we do no "Bill" customers for use if we do not get a valid stop record, but we also configure a maximum session time, because our NAS provider does not support interim updates.
Since the code will only trigger this query on accounting on and off packets, perhaps we should set the AcctStatusType = '%{Acct-Status-Type}' which should result in "Accounting-On" or "Accounting-Off" I just don't like the idea of leaving it set to "Start", and I do agree setting it to "Stop" would be misleading... Other suggestions? -----Original Message----- From: freeradius-devel-bounces+duanec=mail.illicom.net@lists.freeradius.org [mailto:freeradius-devel-bounces+duanec=mail.illicom.net@lists.freeradius.or g] On Behalf Of Guy Fraser Sent: Monday, December 17, 2007 5:28 PM To: FreeRadius developers mailing list Subject: Re: reasoning/question about accounting_onoff_query On 2007-Dec-17, at 15:33, Peter Nixon wrote:
On Mon 17 Dec 2007, Duane Cox wrote:
Correct me if I'm wrong...
But I believe the "accounting_onoff_query" is to be executed by a rebooting nas, or other similiar situation, so that all accounts that are currently "online" or specifiically all accounting records that are open (START), are to be closed, only accounts pertaining to that specific nas.. Well that's how I read the conf file.
If so, souldn't the query also update the AcctStatusType to "Stop" ??
I've looked over all the db examples, and they are pretty much the same, update the StopTime, SessionTime, TerminateCause, etc, but they don't update the StatusType... why?
Possibly, although if there is a acctstoptime then the StatusType is not really necessary. Maybe the StatusType should be set to "off" or something similar to be explicit about how the record was closed... (These type of behaviours are not defined by RFCs so we try to come up with the most logical/usefull setup)
Cheers
I agree with Peter on this one. I would set the Acct-Terminate-Cause to something like NAS-Reset. Setting the Acct-Status-Type to Stop would in fact be misrepresenting the facts. In practice we do no "Bill" customers for use if we do not get a valid stop record, but we also configure a maximum session time, because our NAS provider does not support interim updates. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/devel.html
On Tue 18 Dec 2007, Duane Cox wrote:
Since the code will only trigger this query on accounting on and off packets, perhaps we should set the AcctStatusType = '%{Acct-Status-Type}' which should result in "Accounting-On" or "Accounting-Off"
I just don't like the idea of leaving it set to "Start", and I do agree setting it to "Stop" would be misleading...
While this is not a bad idea, the question is, is it worth another database field (AcctStatusType doesnt exist currently in the schema) given that AcctTerminateCause should already be set with the message sent by the NAS.. Cheers -- Peter Nixon http://peternixon.net/
On Tue 18 Dec 2007, Guy Fraser wrote:
On 2007-Dec-17, at 15:33, Peter Nixon wrote:
On Mon 17 Dec 2007, Duane Cox wrote:
Correct me if I'm wrong...
But I believe the "accounting_onoff_query" is to be executed by a rebooting nas, or other similiar situation, so that all accounts that are currently "online" or specifiically all accounting records that are open (START), are to be closed, only accounts pertaining to that specific nas.. Well that's how I read the conf file.
If so, souldn't the query also update the AcctStatusType to "Stop" ??
I've looked over all the db examples, and they are pretty much the same, update the StopTime, SessionTime, TerminateCause, etc, but they don't update the StatusType... why?
Possibly, although if there is a acctstoptime then the StatusType is not really necessary. Maybe the StatusType should be set to "off" or something similar to be explicit about how the record was closed... (These type of behaviours are not defined by RFCs so we try to come up with the most logical/usefull setup)
Cheers
I agree with Peter on this one. I would set the Acct-Terminate-Cause to something like NAS-Reset. Setting the Acct-Status-Type to Stop would in fact be misrepresenting the facts. In practice we do no "Bill" customers for use if we do not get a valid stop record, but we also configure a maximum session time, because our NAS provider does not support interim updates.
Infact we already set the AcctTerminateCause to what the NAS sends: AcctTerminateCause='%{Acct-Terminate-Cause}' -- Peter Nixon http://peternixon.net/
participants (6)
-
Alan DeKok -
Arran Cudbard-Bell -
Automatic cvs log generator -
Duane Cox -
Guy Fraser -
Peter Nixon