rlm_sql, read_groups
Hello, In revision 1.157 of "src/modules/rlm_sql/rlm_sql.c" the config variable "read_groups" was removed, but is still documented in the example config "raddb/sql.conf" and also used in rlm_authorize() (rlm_sql.c, line 958): if (!inst->config->read_groups) dofallthrough = fallthrough(reply_tmp); Was that by accident or did i again miss something? I really don't like the idea to have half a million "Fall-Through = yes" entries in the radcheck table ;) Regards Stephan Jaeger -- Stephan Jaeger <stephan.jaeger@ewetel.de> EWE TEL GmbH
Stephan Jaeger wrote:
In revision 1.157 of "src/modules/rlm_sql/rlm_sql.c" the config variable "read_groups" was removed, but is still documented in the example config "raddb/sql.conf" and also used in rlm_authorize() (rlm_sql.c, line 958)
Thanks for the report. I've put the read_groups directive back in CVS. -- Nicolas Baradakis
Stephan Jaeger wrote:
In revision 1.157 of "src/modules/rlm_sql/rlm_sql.c" the config variable "read_groups" was removed, but is still documented in the example config "raddb/sql.conf" and also used in rlm_authorize() (rlm_sql.c, line 958):
if (!inst->config->read_groups) dofallthrough = fallthrough(reply_tmp);
Was that by accident or did i again miss something? I really don't like the idea to have half a million "Fall-Through = yes" entries in the radcheck table ;)
No idea. The patch should probably go in. Alan DeKok.
participants (3)
-
Alan DeKok -
Nicolas Baradakis -
Stephan Jaeger