Hello, if you have duplicate clients in clients.conf/sql, there is few output from the server just a "Failed to add client %s". The attached patch also logs an "Duplicate client ip: 1.2.3.4 (foobar)" to L_ERR. In case of a failure in client_add() rlm_sql does only log "generate_sql_clients() returned error". The attached patch also logs "rlm_sql (%s): Failed to add client foobar" like the config parser does. Regards Stephan Jaeger -- Stephan Jaeger <stephan.jaeger@ewetel.de> EWE TEL GmbH
On Fri, 2007-08-03 at 15:15 -0400, Alan DeKok wrote:
if you have duplicate clients in clients.conf/sql, there is few output from the server just a "Failed to add client %s". The attached patch
?
Hmm? The server won't start and is exiting with a "Failed to add client" error. But there is no info why it failed, in this case that a client with this ip address already exists. I've had several dup clients in the nas table, seems that cvs head is more restrictive here than the version i am using up to now. Stephan Jaeger -- Stephan Jaeger <stephan.jaeger@ewetel.de>
Stephan Jaeger wrote:
Hmm? The server won't start and is exiting with a "Failed to add client" error. But there is no info why it failed, in this case that a client with this ip address already exists. I've had several dup clients in the nas table, seems that cvs head is more restrictive here than the version i am using up to now.
Yes... but no patch was attached. Alan DeKok.
On Fri, 2007-08-03 at 21:27 +0100, A.L.M.Buxey@lboro.ac.uk wrote:
why a different error message if its done via clients rather than SQL?
It's not different. One patch adds a generall error message for dup clients, not matter which methods adds them. The other one adds a message for rlm_sql if it failed to add a client. If you use both patches the output should look pretty the same no matter if the client is added from clients.conf or nas table. Stephan Jaeger -- Stephan Jaeger <stephan.jaeger@ewetel.de>
participants (3)
-
A.L.M.Buxey＠lboro.ac.uk -
Alan DeKok -
Stephan Jaeger