Automatic report from sources (radiusd) between 13.09.2005 - 14.09.2005 GMT
CVS log entries from 13.09.2005 (Tue) 08:00:02 - 14.09.2005 (Wed) 08:00:01 GMT ===================================================== Summary by authors ===================================================== Author: aland File: radiusd/src/lib/radius.c; Revisions: 1.162 File: radiusd/src/main/mainconfig.c; Revisions: 1.82 File: radiusd/src/lib/valuepair.c; Revisions: 1.97 File: radiusd/src/modules/rlm_ippool/rlm_ippool.c; Revisions: 1.38 File: radiusd/src/main/listen.c; Revisions: 1.34 File: radiusd/src/include/radiusd.h; Revisions: 1.204 File: radiusd/src/include/libradius.h; Revisions: 1.102 File: radiusd/src/main/request_list.c; Revisions: 1.62 File: radiusd/share/dictionary.bay; Revisions: 1.8 File: radiusd/src/lib/hash.c; Revisions: 1.7 File: radiusd/src/main/conffile.c; Revisions: 1.130 File: radiusd/src/include/request_list.h; Revisions: 1.12 Author: nbk File: radiusd/src/main/crypt.c; Revisions: 1.2 File: radiusd/src/lib/crypt.c; Revisions: 1.6.2.3 Author: phampson File: radiusd/doc/ChangeLog; Revisions: 1.57.2.28 File: radiusd/src/lib/crypt.c; Revisions: 1.6.2.2 File: radiusd/debian/control; Revisions: 1.39.2.6 Author: pnixon File: radiusd/src/modules/rlm_sqlippool/ip_set.h; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/doc/schema_sqlippool_pgsql.sql; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/config.h; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/conf.h; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/Makefile; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/rlm_sql.h; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/config.h.in; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/configure; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/Makefile.in; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/ip_set.c; Revisions: 1.1 File: radiusd/src/modules/rlm_sqlippool/configure.in; Revisions: 1.1 ===================================================== Combined list of identical log entries ===================================================== Description: Move request list to using hashes. It ends up being a bit faster. Modified files: File: radiusd/src/include/libradius.h; Revision: 1.102; Date: 2005/09/13 23:59:55; Author: aland; Lines: (+2 -1) File: radiusd/src/include/request_list.h; Revision: 1.12; Date: 2005/09/13 23:59:55; Author: aland; Lines: (+2 -1) File: radiusd/src/main/listen.c; Revision: 1.34; Date: 2005/09/13 23:59:55; Author: aland; Lines: (+3 -1) File: radiusd/src/main/request_list.c; Revision: 1.62; Date: 2005/09/13 23:59:55; Author: aland; Lines: (+41 -91) ------------------------------- Description: Add new SQL IPPool module to tree. Config files to follow shortly. The module appears to have been worked on my a number of people. Most recent version is thanks to Ruslan A Dautkhanov. Modified files: File: radiusd/src/modules/rlm_sqlippool/Makefile; Revision: 1.1; Date: 2005/09/14 06:58:34; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/Makefile.in; Revision: 1.1; Date: 2005/09/14 06:58:34; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/conf.h; Revision: 1.1; Date: 2005/09/14 06:58:34; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/config.h; Revision: 1.1; Date: 2005/09/14 06:58:34; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/config.h.in; Revision: 1.1; Date: 2005/09/14 06:58:34; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/configure; Revision: 1.1; Date: 2005/09/14 06:58:34; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/configure.in; Revision: 1.1; Date: 2005/09/14 06:58:35; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/ip_set.c; Revision: 1.1; Date: 2005/09/14 06:58:35; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/ip_set.h; Revision: 1.1; Date: 2005/09/14 06:58:35; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/rlm_sql.h; Revision: 1.1; Date: 2005/09/14 06:58:35; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c; Revision: 1.1; Date: 2005/09/14 06:58:35; Author: pnixon; File: radiusd/src/modules/rlm_sqlippool/doc/schema_sqlippool_pgsql.sql; Revision: 1.1; Date: 2005/09/14 06:58:36; Author: pnixon; ------------------------------- Description: Allow NULL as the log destination, in which case logs are thrown away. Mainly useful for performance testing Modified files: File: radiusd/src/include/radiusd.h; Revision: 1.204; Date: 2005/09/14 00:02:30; Author: aland; Lines: (+3 -2) File: radiusd/src/main/mainconfig.c; Revision: 1.82; Date: 2005/09/14 00:02:30; Author: aland; Lines: (+5 -4) ===================================================== Log entries ===================================================== Description: Forgot to build-depend on dpatch Modified files: File: radiusd/debian/control; Revision: 1.39.2.6; Date: 2005/09/13 14:58:00; Author: phampson; Lines: (+1 -1) ------------------------------- Description: Fix missing crypt.h header inclusion Modified files: File: radiusd/doc/ChangeLog; Revision: 1.57.2.28; Date: 2005/09/13 14:00:59; Author: phampson; Lines: (+3 -1) ------------------------------- Description: As posted to the list ny Jonathon De Graeve Modified files: File: radiusd/share/dictionary.bay; Revision: 1.8; Date: 2005/09/13 21:44:59; Author: aland; Lines: (+3 -0) ------------------------------- Description: Pull from CVS HEAD: Don't include unneeded headers. Modified files: File: radiusd/src/lib/crypt.c; Revision: 1.6.2.3; Date: 2005/09/13 14:16:28; Author: nbk; Lines: (+6 -4) ------------------------------- Description: Pull from CVS HEAD: Include crypt.h if it is available so we get a prototype for crypt() Thanks to Konstantin Kubatkin for pointing this out as a segfaulting bug Modified files: File: radiusd/src/lib/crypt.c; Revision: 1.6.2.2; Date: 2005/09/13 13:56:04; Author: phampson; Lines: (+4 -0) ------------------------------- Description: Allow inserts or deletes to happen during walk function Modified files: File: radiusd/src/lib/hash.c; Revision: 1.7; Date: 2005/09/14 01:47:54; Author: aland; Lines: (+10 -4) ------------------------------- Description: More random changes to random Modified files: File: radiusd/src/lib/radius.c; Revision: 1.162; Date: 2005/09/14 00:07:38; Author: aland; Lines: (+9 -22) ------------------------------- Description: If there's nothing to add, don't loop over the input list Modified files: File: radiusd/src/lib/valuepair.c; Revision: 1.97; Date: 2005/09/14 01:03:06; Author: aland; Lines: (+4 -2) ------------------------------- Description: Update checks to match the code a few lines down Modified files: File: radiusd/src/main/conffile.c; Revision: 1.130; Date: 2005/09/13 20:30:19; Author: aland; Lines: (+3 -3) ------------------------------- Description: Don't include unneeded headers. Modified files: File: radiusd/src/main/crypt.c; Revision: 1.2; Date: 2005/09/13 13:59:56; Author: nbk; Lines: (+3 -3) ------------------------------- Description: On an error, dptr may not be free'd Modified files: File: radiusd/src/modules/rlm_ippool/rlm_ippool.c; Revision: 1.38; Date: 2005/09/13 20:25:45; Author: aland; Lines: (+3 -3) ===================================================== Summary of modified files ===================================================== File: radiusd/debian/control Revisions: 1.39.2.6 Authors: phampson (+1 -1) ------------------------------- File: radiusd/doc/ChangeLog Revisions: 1.57.2.28 Authors: phampson (+3 -1) ------------------------------- File: radiusd/share/dictionary.bay Revisions: 1.8 Authors: aland (+3 -0) ------------------------------- File: radiusd/src/include/libradius.h Revisions: 1.102 Authors: aland (+2 -1) ------------------------------- File: radiusd/src/include/radiusd.h Revisions: 1.204 Authors: aland (+3 -2) ------------------------------- File: radiusd/src/include/request_list.h Revisions: 1.12 Authors: aland (+2 -1) ------------------------------- File: radiusd/src/lib/crypt.c Revisions: 1.6.2.3, 1.6.2.2 Authors: nbk (+6 -4), phampson (+4 -0) ------------------------------- File: radiusd/src/lib/hash.c Revisions: 1.7 Authors: aland (+10 -4) ------------------------------- File: radiusd/src/lib/radius.c Revisions: 1.162 Authors: aland (+9 -22) ------------------------------- File: radiusd/src/lib/valuepair.c Revisions: 1.97 Authors: aland (+4 -2) ------------------------------- File: radiusd/src/main/conffile.c Revisions: 1.130 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/main/crypt.c Revisions: 1.2 Authors: nbk (+3 -3) ------------------------------- File: radiusd/src/main/listen.c Revisions: 1.34 Authors: aland (+3 -1) ------------------------------- File: radiusd/src/main/mainconfig.c Revisions: 1.82 Authors: aland (+5 -4) ------------------------------- File: radiusd/src/main/request_list.c Revisions: 1.62 Authors: aland (+41 -91) ------------------------------- File: radiusd/src/modules/rlm_ippool/rlm_ippool.c Revisions: 1.38 Authors: aland (+3 -3) ------------------------------- File: radiusd/src/modules/rlm_sqlippool/Makefile Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/Makefile.in Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/conf.h Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/config.h Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/config.h.in Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/configure Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/configure.in Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/doc/schema_sqlippool_pgsql.sql Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/ip_set.c Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/ip_set.h Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/rlm_sql.h Revisions: 1.1 Authors: pnixon ------------------------------- File: radiusd/src/modules/rlm_sqlippool/rlm_sqlippool.c Revisions: 1.1 Authors: pnixon -- Automatic cron job from /web/pages/us.freeradius.org/bin/new_makelog.pl
===================================================== Combined list of identical log entries ===================================================== Description: Add new SQL IPPool module to tree. Config files to follow shortly. The module appears to have been worked on my a number of people. Most recent version is thanks to Ruslan A Dautkhanov.
Thanks for adding this module, I think it can be useful in a number of cases. However, I didn't see any licence information in the files. Perhaps I'm asking for obvious things because I'm not an expert in legal issues. If this is a module of FreeRADIUS, I think it must be under GPL, but the only information I found in the sources is this line: Copyright 2002 Globe.Net Communications Limited It's unclear for me whether it is a problem with the intellectual property rights. For example, the OpenLDAP project requires that a contribution includes a notice from the author. http://www.openldap.org/devel/contributing.html#notice -- Nicolas Baradakis
Nicolas Baradakis <nbk@sitadelle.com> wrote:
Perhaps I'm asking for obvious things because I'm not an expert in legal issues. If this is a module of FreeRADIUS, I think it must be under GPL, but the only information I found in the sources is this line:
Copyright 2002 Globe.Net Communications Limited
We can ask them for a statement about the license terms. However, they have previously expressed interest in putting it into FreeRADIUS, which is GPL'd.
It's unclear for me whether it is a problem with the intellectual property rights. For example, the OpenLDAP project requires that a contribution includes a notice from the author.
For one, I don't think the concept of public domain exists any more in the U.S. But that's another story. It may be useful to require such a statement, but I think OpenLDAP's license is different (BSD-style), so a notice statement may be more relevant. For us, if the owner of copyrighted code requests that their code be included in the server, that request is based on the knowledge and requirement that the product is GPL'd. Alan DeKok.
On September 15, 2005 1:45:38 PM -0400 Alan DeKok <aland@ox.org> wrote:
Nicolas Baradakis <nbk@sitadelle.com> wrote:
It's unclear for me whether it is a problem with the intellectual property rights. For example, the OpenLDAP project requires that a contribution includes a notice from the author.
For one, I don't think the concept of public domain exists any more in the U.S. But that's another story.
Sure it does. The transition from copyright to public domain may not exist so much, but public domain as such is alive. Hanging by a thread mabye, but alive. FR even includes public domain source: lib/sha1.c.
It may be useful to require such a statement, but I think OpenLDAP's license is different (BSD-style), so a notice statement may be more relevant. For us, if the owner of copyrighted code requests that their code be included in the server, that request is based on the knowledge and requirement that the product is GPL'd.
Not sure why you feel BSD license makes a notice more or less relevant, but in general most people, and even many developers, are naïve when it comes to software licensing. sql_ippool is just one example of many. You can't know for sure how Globe.Net intended to license the software, especially given their demonstrated naïvete made clear by their failure to specify license terms in their source. If they decide they didn't know inclusion meant GPL (or change their mind down the road and claim ignorance), you can be sure the legal battle will be hell. And I just mean the frustration and time spent regardless of who is correct. Let's note that Globe.Net could distribute the module themselves, under any license they choose, no matter that FR is under GPL. They could also distribute a version of FR which has a module which TALKS to their non-GPL code, thus making their code a completely separate entity and not subject to GPL. You really must have explicit license terms in order to include sql_ippool (or any contrib software). -frank
Frank Cusack <fcusack@fcusack.com> wrote:
You can't know for sure how Globe.Net intended to license the software, especially given their demonstrated naïvete made clear by their failure to specify license terms in their source.
They requested that the code be submitted to a project that they knew was licensed under the GPL.
If they decide they didn't know inclusion meant GPL (or change their mind down the road and claim ignorance), you can be sure the legal battle will be hell.
I don't think so. But that's my $0.02.
You really must have explicit license terms in order to include sql_ippool (or any contrib software).
For one-line patches? If that was a serious worry, then nearly every GPL'd project would be vulnerable to the same issues. I'm not worried about it too much. Alan DeKok.
On September 15, 2005 3:12:42 PM -0400 Alan DeKok <aland@ox.org> wrote:
Frank Cusack <fcusack@fcusack.com> wrote:
You can't know for sure how Globe.Net intended to license the software, especially given their demonstrated na??vete made clear by their failure to specify license terms in their source.
They requested that the code be submitted to a project that they knew was licensed under the GPL.
Legally knew?
If they decide they didn't know inclusion meant GPL (or change their mind down the road and claim ignorance), you can be sure the legal battle will be hell.
I don't think so. But that's my $0.02.
Well, not if you simply remove the code.
You really must have explicit license terms in order to include sql_ippool (or any contrib software).
For one-line patches?
No, but I thought the entirety of the module was theirs. If it was just a one liner, it's obviously ok. cvs log seems to indicate it's the entire module.
If that was a serious worry, then nearly every GPL'd project would be vulnerable to the same issues.
Well, even though a one-liner may seem to be obviously ok, GPL has not been tested in court and until such time, every GPL'd project *is* vulnerable. I fail to see why it's difficult to add an explicit GPL header. -frank
Frank Cusack <fcusack@fcusack.com> wrote:
Legally knew?
Talking to the in-house legal staff here, anything can be litigated for any reason by anyone at any time. Who knew what when is not relevant.
Well, not if you simply remove the code.
That's the best solution for problems.
Well, even though a one-liner may seem to be obviously ok, GPL has not been tested in court and until such time, every GPL'd project *is* vulnerable.
I keep hearing that...
I fail to see why it's difficult to add an explicit GPL header.
Yes, we should add one. We should ask them to send us a patch to add one, or state publicly that they're releasing it under the GPL. Alan DeKok.
On Thu, Sep 15, 2005 at 03:12:42PM -0400, Alan DeKok wrote:
Frank Cusack <fcusack@fcusack.com> wrote:
You really must have explicit license terms in order to include sql_ippool (or any contrib software).
For one-line patches?
I think the difference is that a one-line patch creates a derivative work, which the GPL requires be licensed under a GPL-compatible license. And possibly it is too trivial to carry its own copyright. (Someone mentioned recently that the US copyright rules don't recognise trivial programs...) A whole FreeRADIUS module could be argued that it is not a derivative work, but a distinct work intereacting with FreeRADIUS via a defined interface, and therefore subject to copyright on its own. The GPL may still affect distribution of this module (I believe it has something to say on this matter, but can't be bothered quoting chapter and verse) but it doesn't really affect copyright. And while copyright is held by someone else, the licensing must be explicit. (And to be distributed with FreeRADIUS, it must be GPL-compatible I believe.) And then this introduces another module that must be considered in granting an OpenSSL exception to the GPL, as Globe.net may not wish to grant such an exception, and I again can't be bothered to look up to see if we can derive a work from GPL code and license it under GPL + OpenSSL exception without the copyright holder relicensing it. I think this is why projects such as Asterisk (I believe?) requires contributions be assigned copyright to the project, so they don't need to check with everyone who's ever touched the codebase if they need to relicense it. They also use this for dual-licensing the code to commercial users who do not want to deal with the GPL. (I'm not saying Asterisk does it better, or worse. Just mentioning what they do to deal with this problem.) -- ----------------------------------------------------------- Paul "TBBle" Hampson, MCSE 8th year CompSci/Asian Studies student, ANU The Boss, Bubblesworth Pty Ltd (ABN: 51 095 284 361) Paul.Hampson@Pobox.Com Of course Pacman didn't influence us as kids. If it did, we'd be running around in darkened rooms, popping pills and listening to repetitive music. -- Kristian Wilson, Nintendo, Inc, 1989 License: http://creativecommons.org/licenses/by/2.1/au/ -----------------------------------------------------------
Paul TBBle Hampson <Paul.Hampson@Pobox.com> wrote:
And then this introduces another module that must be considered in granting an OpenSSL exception to the GPL,
THAT I don't see a problem with. Their module doesn't like to OpenSSL, so their opinion is irrelevant. The EAP code links to OpenSSL, as does the server core. So the people with copyright on EAP and the server core need to make statements about linking to OpenSSL. Personally, I'm OK with it.
as Globe.net may not wish to grant such an exception, and I again can't be bothered to look up to see if we can derive a work from GPL code and license it under GPL + OpenSSL exception without the copyright holder relicensing it.
We can't. But their opinion doesn't matter.
(I'm not saying Asterisk does it better, or worse. Just mentioning what they do to deal with this problem.)
Sure. Personally, I dislike asking people to assign copyright. But asking people to explicitly license their code under the GPL is a good idea. Alan DeKok.
On Friday 16 September 2005 07:50, Paul TBBle Hampson wrote:
I think this is why projects such as Asterisk (I believe?) requires contributions be assigned copyright to the project, so they don't need to check with everyone who's ever touched the codebase if they need to relicense it. They also use this for dual-licensing the code to commercial users who do not want to deal with the GPL.
(I'm not saying Asterisk does it better, or worse. Just mentioning what they do to deal with this problem.)
Digium (Asterisk) requires the (poorly named) disclaimer to be signed so that they can commercially license the code. Nothing more nothing less.. -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
On Thursday 15 September 2005 12:31, Nicolas Baradakis wrote:
===================================================== Combined list of identical log entries ===================================================== Description: Add new SQL IPPool module to tree. Config files to follow shortly. The module appears to have been worked on my a number of people. Most recent version is thanks to Ruslan A Dautkhanov.
Thanks for adding this module, I think it can be useful in a number of cases. However, I didn't see any licence information in the files.
Perhaps I'm asking for obvious things because I'm not an expert in legal issues. If this is a module of FreeRADIUS, I think it must be under GPL, but the only information I found in the sources is this line:
Copyright 2002 Globe.Net Communications Limited
It's unclear for me whether it is a problem with the intellectual property rights. For example, the OpenLDAP project requires that a contribution includes a notice from the author.
Yep. It is a very usefull module. We are actually in the process of rewriting half of it so that it only needs one copy of itself to server all IP Pools. That should make it scale linearly and mean that FeeRADIUS' config files do not need to be touched to add a new pool. (No reload) Cheers -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
participants (6)
-
Alan DeKok -
Automatic cvs log generator -
Frank Cusack -
Nicolas Baradakis -
Paul TBBle Hampson -
Peter Nixon