some issues in sqlippool, branch_1_1
Hello! 1. During setup of rlm_sqlippool module, I found some compatibility issues with PostgreSQL server. I remind that rlm_sqlippool uses transactions. In that case all of queries and commands including "BEGIN", "COMMIT" and "ROLLBACK" in PostgreSQL must ends with ";" or query will fail. I have this issue (is it an issue?) on PostgreSQL 7.3.15 but it should be true for 8.x versions too. I think it should be documented. 2. In sqlippool.conf %{reply:Pool-Name} is used, but in documentation said that Pool-Name is check attribute. In my tests reply:Pool-Name was empty string, so I replaced it with Pool-Name. 3. In doc/examples/postgresql.sql in radippool table definition some fields are defined as NOT NULL (and vice versa), which should not be - it causes problems when one add IP-addresses to radippool. 4. In src/include/modpriv.h , src/modules/rlm_eap/rlm_eap.h , src/modules/rlm_sql/rlm_sql.h I replaced #include "ltdl.h" with #include "../../libltdl/ltdl.h" to compile FreeRadius. My OS is FreeBSD 6.2-RELEASE, GNU Make 3.81 Patch for items 2 and 3 attached. With best regards, Alexander V. Klepikov. E-mail: klepikov_a@up.ua
On Tue 17 Apr 2007, Alexander V. Klepikov wrote:
Hello!
1. During setup of rlm_sqlippool module, I found some compatibility issues with PostgreSQL server. I remind that rlm_sqlippool uses transactions. In that case all of queries and commands including "BEGIN", "COMMIT" and "ROLLBACK" in PostgreSQL must ends with ";" or query will fail. I have this issue (is it an issue?) on PostgreSQL 7.3.15 but it should be true for 8.x versions too. I think it should be documented.
Hi Alexander I will check out your patch tomorrow. I do recommend that you consider running CVS head (which will soon be FreeRADIUS 2.0) as I have done a fair amount of new development rlm_sqlippool which is not backported to branch_1_1 I run multiple instances of rlm_sqlippool with cvs head in production on postgresql-8.1.4 Thanks for your input Regards -- Peter Nixon http://www.peternixon.net/ PGP Key: http://www.peternixon.net/public.asc
participants (2)
-
Alexander V. Klepikov -
Peter Nixon