pass_all_vps option for rlm_python
Hello, I found the not described option `pass_all_vps` for rlm_python module. Is this option intended only for testing? I am asking because neither https://wiki.freeradius.org/modules/Rlm_python page, neither default python config files from `.../raddb/mods-available` does not say anything about this options. I am -- Vladimir
On Sep 27, 2018, at 1:16 PM, work vlpl <thework.vlpl@gmail.com> wrote:
Hello,
I found the not described option `pass_all_vps` for rlm_python module.
Where did you find that option?
Is this option intended only for testing? I am asking because neither https://wiki.freeradius.org/modules/Rlm_python page, neither default python config files from `.../raddb/mods-available` does not say anything about this options.
Then the option doesn't exist. Alan DeKok.
Where did you find that option? https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_... https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_...
https://github.com/FreeRADIUS/freeradius-server/pull/2031
Then the option doesn't exist. Well, in my tests this option is exist and working. I am asking about this option in case this option turns out to be a test and will be deleted in the future releases.
-- Vladimir
On Sep 28, 2018, at 2:39 PM, work vlpl <thework.vlpl@gmail.com> wrote:
Where did you find that option? https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_... https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_...
https://github.com/FreeRADIUS/freeradius-server/pull/2031
Then the option doesn't exist. Well, in my tests this option is exist and working. I am asking about this option in case this option turns out to be a test and will be deleted in the future releases.
We don't generally tend to strip out functionality so It'll likely stick around for the rest of the v3.0.x series and would only be removed if there was something that provided equivalent functionality in v4.0.x. -Arran
On Sep 28, 2018, at 2:39 PM, work vlpl <thework.vlpl@gmail.com> wrote:
Where did you find that option? https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_... https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/modules/rlm_...
https://github.com/FreeRADIUS/freeradius-server/pull/2031
Then the option doesn't exist. Well, in my tests this option is exist and working. I am asking about this option in case this option turns out to be a test and will be deleted in the future releases. We don't generally tend to strip out functionality so It'll likely stick around for the rest of the v3.0.x series and would only be removed if there was something that provided equivalent functionality in v4.0.x.
I hope it won't get deleted :). I wrote that option because the Python module was having access only to the Request, and have no access to the rest of information (e.g. config, reply...). I needed to access it for a couple of use cases: basically a module on a Proxy that needed to rewrite some of the attributes (hence having access to the reply list), and recently a module that includes support for TOTP (by rewriting Cleartext-Password, from the Config list, as the original value plus the TOTP code). But it is true that I did not write any documentation for it, nor was it requested. If you think I should, I have no problems on writing some lines that make this option more official. Regards, Alejandro
-Arran - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
-- Alejandro Perez-Mendez Technical Specialist (AAA), Trust & Identity M (+34) 619 333 219 Skype alejandro_perez_mendez jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800. Jisc Services Limited is a wholly owned Jisc subsidiary and a company limited by guarantee which is registered in England under company number 2881024, VAT number GB 197 0632 86. The registered office is: One Castle Park, Tower Hill, Bristol BS2 0JA. T 0203 697 5800.
On Sep 29, 2018, at 6:24 PM, Alejandro Perez-Mendez <alex.perez-mendez@jisc.ac.uk> wrote:
I hope it won't get deleted :). I wrote that option because the Python module was having access only to the Request, and have no access to the rest of information (e.g. config, reply...). I needed to access it for a couple of use cases: basically a module on a Proxy that needed to rewrite some of the attributes (hence having access to the reply list), and recently a module that includes support for TOTP (by rewriting Cleartext-Password, from the Config list, as the original value plus the TOTP code).
We'll do it another way in v4. The issue with v3 is that we can't change existing functionality, as millions of people depend on it.
But it is true that I did not write any documentation for it, nor was it requested. If you think I should, I have no problems on writing some lines that make this option more official.
I'd prefer to wait... Alan DeKok.
El 30/9/18 a las 13:17, Alan DeKok escribió:
On Sep 29, 2018, at 6:24 PM, Alejandro Perez-Mendez <alex.perez-mendez@jisc.ac.uk> wrote:
I hope it won't get deleted :). I wrote that option because the Python module was having access only to the Request, and have no access to the rest of information (e.g. config, reply...). I needed to access it for a couple of use cases: basically a module on a Proxy that needed to rewrite some of the attributes (hence having access to the reply list), and recently a module that includes support for TOTP (by rewriting Cleartext-Password, from the Config list, as the original value plus the TOTP code). We'll do it another way in v4. The issue with v3 is that we can't change existing functionality, as millions of people depend on it.
Absolutely. That's why we chose to add an additional option instead of modifying existing behaviour.
But it is true that I did not write any documentation for it, nor was it requested. If you think I should, I have no problems on writing some lines that make this option more official. I'd prefer to wait...
Sure. When v4 gets out, how long do you expect to extend support for v3? Alejandro
Alan DeKok.
- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
-- Alejandro Perez-Mendez Technical Specialist (AAA), Trust & Identity M (+34) 619 333 219 Skype alejandro_perez_mendez jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800. Jisc Services Limited is a wholly owned Jisc subsidiary and a company limited by guarantee which is registered in England under company number 2881024, VAT number GB 197 0632 86. The registered office is: One Castle Park, Tower Hill, Bristol BS2 0JA. T 0203 697 5800.
On Oct 1, 2018, at 2:24 AM, Alejandro Perez-Mendez <alex.perez-mendez@jisc.ac.uk> wrote:
Sure. When v4 gets out, how long do you expect to extend support for v3?
v3 will be supported for the foreseeable future. One reason is that v4 is becoming substantially different from v3. For simple RADIUS servers, v3 is fine. v4 is more complex than v3. For a large percentage of common use-cases, that complexity will confuse people, for no benefit. Alan DeKok.
participants (4)
-
Alan DeKok -
Alejandro Perez-Mendez -
Arran Cudbard-Bell -
work vlpl