Is anyone using dialup_admin with a PHP version newer than 4.2.0?
Hi, all, This is a refinement of my earlier request for information, honed after half a week of trying to untangle things. I've been grubbing through all the code for dialup_admin 1.80 (from the 20070320 CVS snapshot) and am entirely unconvinced that it works with version of PHP newer than 4.2.0. I'm using PHP 4.3.0, since that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc. Let's take $login as an example. In config.php3, there's code to scrub "bad" characters out of it, and to strip the realm if requested. Unfortunately, in my environment, just going to the entry point of the dialup_admin application results in... [client 127.0.0.1] PHP Notice: Undefined variable: login in /usr/local/dialup_admin/conf/config.php3 on line 92, referer: http://localhost/dialup/ [client 127.0.0.1] PHP Notice: Undefined variable: login in /usr/local/dialup_admin/conf/config.php3 on line 95, referer: http://localhost/dialup/ (ignore the exact line numbers - they won't match the code in CVS because I have some debugging stuff further up right now). I realize that this is a "notice" level message and that messages can be turned off by twiddling error_reporting, but that's not the point - the point is not simply that there are hundreds of these 'notices' getting logged when I bounce around dialup_admin. The point is that these notices are caused by PHP trying to "do the right thing" and getting it wrong because the dialup_admin code is chock-a-block with $login rather than the now-accepted practice of $_GET['login], and in any case, because of how the URLs and PHP code interrelate, modules like config.php3 aren't always called from other modules that were invoked with a GET method with those exact elements, thus variables like $login and $find_user and any other variables which appear to be implicly created under older versions of PHP might or might not be defined, but the code is written as if they are always defined, albeit occasionally empty. I'm entirely willing to accept that I've missed a step in the installation, but I did try to follow the steps in the TODO file and don't believe I missed any. Do people just use the freeRADIUS server and manipulate the user database manually? Are there any dialup_admin users running on operating systems less than a year old? All I'm really after is a user management GUI - I don't really care if it's dialup_admin or not. If there's something that other people prefer, I'd love to hear about it. In terms of getting this all going, I'm about to start forcing variables to be something useful, as in... $login = ""; $max_results = ""; if (!empty($_GET)) { $login = $_GET['login']; $max_results = $_GET['max_results']; } ... just to quiet down the logged errors in the code so I can drill down to why I can't click on "new user" and get a page that lets me enter a new user. I'm also open to other suggestions to clean up the dialup_admin code and get it up to snuff w.r.t. presently-shipping versions of PHP. This will be an essential step to getting this code running under php5, as all of these globalisms have been deprecated because they lead to massive vulnerabilities. Thanks, -ethan
O/H Ethan Dicks έγραψε:
Hi, all,
This is a refinement of my earlier request for information, honed after half a week of trying to untangle things.
I've been grubbing through all the code for dialup_admin 1.80 (from the 20070320 CVS snapshot) and am entirely unconvinced that it works with version of PHP newer than 4.2.0. I'm using PHP 4.3.0, since that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc.
Let's take $login as an example. In config.php3, there's code to scrub "bad" characters out of it, and to strip the realm if requested. Unfortunately, in my environment, just going to the entry point of the dialup_admin application results in...
[client 127.0.0.1] PHP Notice: Undefined variable: login in /usr/local/dialup_admin/conf/config.php3 on line 92, referer: http://localhost/dialup/ [client 127.0.0.1] PHP Notice: Undefined variable: login in /usr/local/dialup_admin/conf/config.php3 on line 95, referer: http://localhost/dialup/
Well as you probably have seen config.php3 will call import_request_variables('GPC') so you should not normally have problems with variables like $login. I have dialupadmin running on php-5.0.3 without a problem.
(ignore the exact line numbers - they won't match the code in CVS because I have some debugging stuff further up right now).
I realize that this is a "notice" level message and that messages can be turned off by twiddling error_reporting, but that's not the point - the point is not simply that there are hundreds of these 'notices' getting logged when I bounce around dialup_admin. The point is that these notices are caused by PHP trying to "do the right thing" and getting it wrong because the dialup_admin code is chock-a-block with $login rather than the now-accepted practice of $_GET['login], and in any case, because of how the URLs and PHP code interrelate, modules like config.php3 aren't always called from other modules that were invoked with a GET method with those exact elements, thus variables like $login and $find_user and any other variables which appear to be implicly created under older versions of PHP might or might not be defined, but the code is written as if they are always defined, albeit occasionally empty.
I'm entirely willing to accept that I've missed a step in the installation, but I did try to follow the steps in the TODO file and don't believe I missed any. Do people just use the freeRADIUS server and manipulate the user database manually? Are there any dialup_admin users running on operating systems less than a year old? All I'm really after is a user management GUI - I don't really care if it's dialup_admin or not. If there's something that other people prefer, I'd love to hear about it.
In terms of getting this all going, I'm about to start forcing variables to be something useful, as in...
$login = ""; $max_results = "";
if (!empty($_GET)) { $login = $_GET['login']; $max_results = $_GET['max_results']; }
... just to quiet down the logged errors in the code so I can drill down to why I can't click on "new user" and get a page that lets me enter a new user. I'm also open to other suggestions to clean up the dialup_admin code and get it up to snuff w.r.t. presently-shipping versions of PHP. This will be an essential step to getting this code running under php5, as all of these globalisms have been deprecated because they lead to massive vulnerabilities.
Thanks,
-ethan - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
On 3/21/07, Kostas Kalevras <kkalev@noc.ntua.gr> wrote:
O/H Ethan Dicks έγραψε:
... I'm using PHP 4.3.0, since that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc.
Well as you probably have seen config.php3 will call import_request_variables('GPC') so you should not normally have problems with variables like $login.
Hmm... I have seen that call at the top of config.php3, but I'm seeing behavior that's consistent with it not working. Odd.
I have dialupadmin running on php-5.0.3 without a problem.
Thank you for letting me know that it works with a newer version of php. I'm back to the drawing board about where I might be missing an installation step, then. Thanks, -ethan
On 3/21/07, Ethan Dicks <ethan.dicks@gmail.com> wrote:
On 3/21/07, Kostas Kalevras <kkalev@noc.ntua.gr> wrote:
O/H Ethan Dicks έγραψε:
... I'm using PHP 4.3.0, since
PHP 4.3.9-3.22.3, for the record.
that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc.
I have dialupadmin running on php-5.0.3 without a problem.
Well... I'm about ready to give up on dialup_admin with RedHat Enterprise 4. I was able to get dialup_admin to work in seconds on an old RedHat 9 box in the corner (PHP 4.2.2-17.2) by copying over my working directory from the RHES4 box. There is, I conclude, nothing wrong with my dialup_admin install (based off of a fresh copy from CVS). All I can figure is that there is some bug with global variables with PHP 4.3. One more test I did was to put in some 'echo' statements into various files. It seems that variables like the $mappings and $config arrays are entirely known to config.php3, but not their callers, like user_test.php3 or help.php3. I was able to get more sane behavior by shotgunning global statements throughout the dialup_admin code, but I have not been able to get a sensible display from something as simple as clicking on "add user". I do not have a working php5 environment at hand, so testing under that is a whole 'nother set of problems to solve. Back to a form of my original query, has anyone gotten dialup_admin working specifically with PHP 4.3? Thanks, -ethan
On 27 Mar 2007, at 10:11 PM, Ethan Dicks wrote:
On 3/21/07, Ethan Dicks <ethan.dicks@gmail.com> wrote:
On 3/21/07, Kostas Kalevras <kkalev@noc.ntua.gr> wrote:
O/H Ethan Dicks έγραψε:
... I'm using PHP 4.3.0, since
PHP 4.3.9-3.22.3, for the record.
that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc.
I have dialupadmin running on php-5.0.3 without a problem.
Well... I'm about ready to give up on dialup_admin with RedHat Enterprise 4. I was able to get dialup_admin to work in seconds on an old RedHat 9 box in the corner (PHP 4.2.2-17.2) by copying over my working directory from the RHES4 box. There is, I conclude, nothing wrong with my dialup_admin install (based off of a fresh copy from CVS). All I can figure is that there is some bug with global variables with PHP 4.3. Hi
I was using PHP 5.1.x at a previous employer, but their dial-up admin interface was quite hacked by a freelancer. Regards --jm
One more test I did was to put in some 'echo' statements into various files. It seems that variables like the $mappings and $config arrays are entirely known to config.php3, but not their callers, like user_test.php3 or help.php3. I was able to get more sane behavior by shotgunning global statements throughout the dialup_admin code, but I have not been able to get a sensible display from something as simple as clicking on "add user".
I do not have a working php5 environment at hand, so testing under that is a whole 'nother set of problems to solve. Back to a form of my original query, has anyone gotten dialup_admin working specifically with PHP 4.3?
Thanks,
-ethan
- List info/subscribe/unsubscribe? See http://www.freeradius.org/list/ users.html
-- Jacques Marneweck http://www.powertrip.co.za/ http://www.powertrip.co.za/blog/ #include <std/disclaimer.h>
O/H Ethan Dicks έγραψε:
Hi, all,
This is a refinement of my earlier request for information, honed after half a week of trying to untangle things.
I've been grubbing through all the code for dialup_admin 1.80 (from the 20070320 CVS snapshot) and am entirely unconvinced that it works with version of PHP newer than 4.2.0. I'm using PHP 4.3.0, since that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc.
Let's take $login as an example. In config.php3, there's code to scrub "bad" characters out of it, and to strip the realm if requested. Unfortunately, in my environment, just going to the entry point of the dialup_admin application results in...
[client 127.0.0.1] PHP Notice: Undefined variable: login in /usr/local/dialup_admin/conf/config.php3 on line 92, referer: http://localhost/dialup/ [client 127.0.0.1] PHP Notice: Undefined variable: login in /usr/local/dialup_admin/conf/config.php3 on line 95, referer: http://localhost/dialup/
Well as you probably have seen config.php3 will call import_request_variables('GPC') so you should not normally have problems with variables like $login. I have dialupadmin running on php-5.0.3 without a problem.
(ignore the exact line numbers - they won't match the code in CVS because I have some debugging stuff further up right now).
I realize that this is a "notice" level message and that messages can be turned off by twiddling error_reporting, but that's not the point - the point is not simply that there are hundreds of these 'notices' getting logged when I bounce around dialup_admin. The point is that these notices are caused by PHP trying to "do the right thing" and getting it wrong because the dialup_admin code is chock-a-block with $login rather than the now-accepted practice of $_GET['login], and in any case, because of how the URLs and PHP code interrelate, modules like config.php3 aren't always called from other modules that were invoked with a GET method with those exact elements, thus variables like $login and $find_user and any other variables which appear to be implicly created under older versions of PHP might or might not be defined, but the code is written as if they are always defined, albeit occasionally empty.
I'm entirely willing to accept that I've missed a step in the installation, but I did try to follow the steps in the TODO file and don't believe I missed any. Do people just use the freeRADIUS server and manipulate the user database manually? Are there any dialup_admin users running on operating systems less than a year old? All I'm really after is a user management GUI - I don't really care if it's dialup_admin or not. If there's something that other people prefer, I'd love to hear about it.
In terms of getting this all going, I'm about to start forcing variables to be something useful, as in...
$login = ""; $max_results = "";
if (!empty($_GET)) { $login = $_GET['login']; $max_results = $_GET['max_results']; }
... just to quiet down the logged errors in the code so I can drill down to why I can't click on "new user" and get a page that lets me enter a new user. I'm also open to other suggestions to clean up the dialup_admin code and get it up to snuff w.r.t. presently-shipping versions of PHP. This will be an essential step to getting this code running under php5, as all of these globalisms have been deprecated because they lead to massive vulnerabilities.
Thanks,
-ethan - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
Hi, all,
This is a refinement of my earlier request for information, honed after half a week of trying to untangle things.
I've been grubbing through all the code for dialup_admin 1.80 (from the 20070320 CVS snapshot) and am entirely unconvinced that it works with version of PHP newer than 4.2.0. I'm using PHP 4.3.0, since that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc.
[...]
Well as you probably have seen config.php3 will call import_request_variables('GPC') so you should not normally have problems with variables like $login. I have dialupadmin running on php-5.0.3 without a problem.
I have a working setup from 4.4.0 - 4.4.6. PHP is configured with: ./configure --with-apxs2=/usr/local/httpd/bin/apxs \ --disable-cgi --with-gettext --with-pear \ --with-mysql=/usr/local/mysql Perhaps a comparison between our phpinfo() outputs would help? Michael
On 3/28/07, Muenz, Michael <m.muenz@spam-fetish.org> wrote:
Ethan Dicks wrote:
I've been grubbing through all the code for dialup_admin 1.80 (from the 20070320 CVS snapshot) and am entirely unconvinced that it works with version of PHP newer than 4.2.0. I'm using PHP 4.3.0, since that's what comes with RedHat Enterprise Linux 4. I've turned on register_globals, but I can't get the dialup_admin code to stop throwing warnings about variable names, etc.
Well as you probably have seen config.php3 will call import_request_variables('GPC') so you should not normally have problems with variables like $login. I have dialupadmin running on php-5.0.3 without a problem.
I have a working setup from 4.4.0 - 4.4.6. PHP is configured with: ./configure --with-apxs2=/usr/local/httpd/bin/apxs \ --disable-cgi --with-gettext --with-pear \ --with-mysql=/usr/local/mysql
Perhaps a comparison between our phpinfo() outputs would help?
OK... I'll give that a shot. Here's just the configure line (from phpinfo()) for my php 4.3.9 install... './configure' '--build=i686-redhat-linux-gnu' '--host=i686-redhat-linux-gnu' '--target=i386-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/usr/com' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--cache-file=../config.cache' '--with-config-file-path=/etc' '--with-config-file-scan-dir=/etc/php.d' '--enable-force-cgi-redirect' '--disable-debug' '--enable-pic' '--disable-rpath' '--enable-inline-optimization' '--with-bz2' '--with-db4=/usr' '--with-curl' '--with-exec-dir=/usr/bin' '--with-freetype-dir=/usr' '--with-png-dir=/usr' '--with-gd=shared' '--enable-gd-native-ttf' '--without-gdbm' '--with-gettext' '--with-ncurses=shared' '--with-gmp' '--with-iconv' '--with-jpeg-dir=/usr' '--with-openssl' '--with-png' '--with-pspell' '--with-xml' '--with-expat-dir=/usr' '--with-dom=shared,/usr' '--with-dom-xslt=/usr' '--with-dom-exslt=/usr' '--with-xmlrpc=shared' '--with-pcre-regex=/usr' '--with-zlib' '--with-layout=GNU' '--enable-bcmath' '--enable-exif' '--enable-ftp' '--enable-magic-quotes' '--enable-sockets' '--enable-sysvsem' '--enable-sysvshm' '--enable-track-vars' '--enable-trans-sid' '--enable-yp' '--enable-wddx' '--with-pear=/usr/share/pear' '--with-imap=shared' '--with-imap-ssl' '--with-kerberos' '--with-ldap=shared' '--with-mysql=shared,/usr' '--with-pgsql=shared' '--with-snmp=shared,/usr' '--with-snmp=shared' '--enable-ucd-snmp-hack' '--with-unixODBC=shared,/usr' '--enable-memory-limit' '--enable-shmop' '--enable-calendar' '--enable-dbx' '--enable-dio' '--enable-mbstring=shared' '--enable-mbstr-enc-trans' '--enable-mbregex' '--with-mime-magic=/usr/share/file/magic.mime' '--with-apxs2=/usr/sbin/apxs' I just freshly installed the rpm with up2date. -ethan
participants (4)
-
Ethan Dicks -
Jacques Marneweck -
Kostas Kalevras -
Muenz, Michael