3.0.11: unjustified warning on startup
Hi, this here is shown on startup: "raddb/clients/staff[232]: The item 'staff_type' is defined, but is unused by the configuration" But it's not correct... yes, I set a custom attribute staff_type inside a client {} there, but I *do* use it in configuration, in statements like this: update request { &RESTENA-Service-Type = "Staff-%{client:staff_type}" } or: if ( "%{client:staff_type}" == "Nagios-Login" [...] Could the warnings be made more clever? It is sure useful to be warned about unused things for cleanup of configs, but only if the things are *really* unused. Greetings, Stefan Winter -- Stefan WINTER Ingenieur de Recherche Fondation RESTENA - Réseau Téléinformatique de l'Education Nationale et de la Recherche 2, avenue de l'Université L-4365 Esch-sur-Alzette Tel: +352 424409 1 Fax: +352 422473 PGP key updated to 4096 Bit RSA - I will encrypt all mails if the recipient's key is known to me http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xC0DE6A358A39DC66
On Feb 10, 2016, at 4:21 AM, Stefan Winter <stefan.winter@restena.lu> wrote:
this here is shown on startup:
"raddb/clients/staff[232]: The item 'staff_type' is defined, but is unused by the configuration"
That should probably be moved to just a debug message.
But it's not correct... yes, I set a custom attribute staff_type inside a client {} there, but I *do* use it in configuration, in statements like this:
update request { &RESTENA-Service-Type = "Staff-%{client:staff_type}" }
Hmm... I see. The difficulty is that there's no "parse" callback for the dynamic expansions. as in "Here's some text, is it correct?" That would be needed in order to fix this issue.
Could the warnings be made more clever? It is sure useful to be warned about unused things for cleanup of configs, but only if the things are *really* unused.
Telling what's really unused isn't trivial. :( Alan DeKok.
On 10 Feb 2016, at 06:18, Alan DeKok <aland@deployingradius.com> wrote:
On Feb 10, 2016, at 4:21 AM, Stefan Winter <stefan.winter@restena.lu> wrote:
this here is shown on startup:
"raddb/clients/staff[232]: The item 'staff_type' is defined, but is unused by the configuration"
That should probably be moved to just a debug message.
But then people will ignore them :(
But it's not correct... yes, I set a custom attribute staff_type inside a client {} there, but I *do* use it in configuration, in statements like this:
update request { &RESTENA-Service-Type = "Staff-%{client:staff_type}" }
Hmm... I see. The difficulty is that there's no "parse" callback for the dynamic expansions. as in "Here's some text, is it correct?"
That would be needed in order to fix this issue.
Yeah, we'd need something similar to what we have for the map proc stuff. -Arran Arran Cudbard-Bell <a.cudbardb@freeradius.org> FreeRADIUS development team FD31 3077 42EC 7FCD 32FE 5EE2 56CF 27F9 30A8 CAA2
On Wed, Feb 10, 2016 at 07:35:32AM -0800, Arran Cudbard-Bell wrote:
On 10 Feb 2016, at 06:18, Alan DeKok <aland@deployingradius.com> wrote:
On Feb 10, 2016, at 4:21 AM, Stefan Winter <stefan.winter@restena.lu> wrote:
this here is shown on startup:
"raddb/clients/staff[232]: The item 'staff_type' is defined, but is unused by the configuration"
That should probably be moved to just a debug message.
But then people will ignore them :(
Just change it to "The item 'staff_type' is defined, but might not be used by the configuration" If in doubt, make sure nobody else is sure either :-) Matthew -- Matthew Newton, Ph.D. <mcn4@le.ac.uk> Systems Specialist, Infrastructure Services, I.T. Services, University of Leicester, Leicester LE1 7RH, United Kingdom For IT help contact helpdesk extn. 2253, <ithelp@le.ac.uk>
participants (4)
-
Alan DeKok -
Arran Cudbard-Bell -
Matthew Newton -
Stefan Winter