3.0.0 return code priority / change?
All, Seems that the return code priority is behaving different in 3.0 - specifically the following config: authorize { updated files if (noop) { ... } } ...gives: (0) authorize { (0) [updated] = updated (0) [files] = noop (0) ? if (noop) (0) ? if (noop) -> FALSE i.e. the "noop" from the files module is ignored. This is a change from 2.x where the most recent module return code can be checked. Have I missed the change, or is this not intentional?
On 14/10/13 16:18, Phil Mayers wrote:
i.e. the "noop" from the files module is ignored. This is a change from 2.x where the most recent module return code can be checked.
Have I missed the change, or is this not intentional?
Looks like this happened in the modcall.c rewrite (d0aa96709cea) and has been ported to 2.x as well, so it'll change there too? https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/main/modcall...
On 14/10/13 17:15, Phil Mayers wrote:
On 14/10/13 16:18, Phil Mayers wrote:
i.e. the "noop" from the files module is ignored. This is a change from 2.x where the most recent module return code can be checked.
Have I missed the change, or is this not intentional?
Looks like this happened in the modcall.c rewrite (d0aa96709cea) and has been ported to 2.x as well, so it'll change there too?
Fix seems easy; assuming the old behaviour is what's wanted: https://github.com/philmayers/freeradius-server/commit/51c43419
participants (1)
-
Phil Mayers