Re: key_expiration variable not defined anywhere (in trustrouter.c in rlm_realm)
I messed up with git. This is the actual PR (https://github.com/FreeRADIUS/freeradius-server/pull/2114) El 09/11/17 a las 08:32, Alejandro Pérez Méndez escribió:
Hi Stefan,
you are right. Sadly the first line of my original commit (https://github.com/FreeRADIUS/freeradius-server/pull/2059/commits/c5cebd2e97...) was lost. Nothing too serious. The following PR should fix it (https://github.com/FreeRADIUS/freeradius-server/pull/2113).
Regards, Alejandro
El 09/11/17 a las 00:29, Stefan Paetow escribió:
Hi Alan,
During the build to make this all work with OpenSSL, I noticed that 'key_expiration' is used for the first time in line 422 of trustrouter.c in the rlm_realm module. According to Github this was a manual merge? Did something go missing (the declaration of key_expiration perhaps)?
Build output snippet:
-- begin --
CC src/modules/rlm_realm/trustrouter.c src/modules/rlm_realm/trustrouter.c: In function ‘srvr_blk_to_home_server’: src/modules/rlm_realm/trustrouter.c:422:36: error: ‘key_expiration’ undeclared (first use in this function); did you mean ‘get_realm_expiration’? tid_srvr_get_key_expiration(blk, &key_expiration); ^~~~~~~~~~~~~~ get_realm_expiration src/modules/rlm_realm/trustrouter.c:422:36: note: each undeclared identifier is reported only once for each function it appears in make: *** [scripts/boiler.mk:635: build/objs/src/modules/rlm_realm/trustrouter.lo] Error 1
-- end --
Could you have a look? I've copied Alex in, just in case.
Thank you very much!
With Regards
Stefan Paetow Moonshot Industry & Research Liaison Coordinator
t: +44 (0)1235 822 125 gpg: 0x3FCE5142 xmpp: stefanp@jabber.dev.ja.net skype: stefan.paetow.janet
jisc.ac.uk
Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800.
I messed up with git. This is the actual PR (https://github.com/FreeRADIUS/freeradius-server/pull/2114)
Thanks, Alex! While I could generate my pull request, I really don't want to check this in and submit before testing it... since all the components that are involved in generating the GSS-EAP mechanism use OpenSSL 1.0.x, I am going down a rabbit hole where going to 1.1.x is concerned... Shall we proceed at risk? :-/ Stefan Paetow Moonshot Industry & Research Liaison Coordinator t: +44 (0)1235 822 125 gpg: 0x3FCE5142 xmpp: stefanp@jabber.dev.ja.net skype: stefan.paetow.janet jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800.
Right, I've submitted this 'at risk'... it compiles cleanly with trust router development libraries available. But whether it *works* is another question... Stefan Paetow Moonshot Industry & Research Liaison Coordinator t: +44 (0)1235 822 125 gpg: 0x3FCE5142 xmpp: stefanp@jabber.dev.ja.net skype: stefan.paetow.janet jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800. On 09/11/2017, 16:58, "Freeradius-Users on behalf of Stefan Paetow" <freeradius-users-bounces+stefan.paetow=jisc.ac.uk@lists.freeradius.org on behalf of Stefan.Paetow@jisc.ac.uk> wrote: > I messed up with git. This is the actual PR (https://github.com/FreeRADIUS/freeradius-server/pull/2114) Thanks, Alex! While I could generate my pull request, I really don't want to check this in and submit before testing it... since all the components that are involved in generating the GSS-EAP mechanism use OpenSSL 1.0.x, I am going down a rabbit hole where going to 1.1.x is concerned... Shall we proceed at risk? :-/ Stefan Paetow Moonshot Industry & Research Liaison Coordinator t: +44 (0)1235 822 125 gpg: 0x3FCE5142 xmpp: stefanp@jabber.dev.ja.net skype: stefan.paetow.janet jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800.
Ok, Alan, I think once this PR is in the bag, 3.0.16 is ready to go out! Code compiles on both OpenSSL 1.0.2 (CentOS 7) and OpenSSL 1.1.0 (Fedora 26). Given that we don't yet support v1.1 in the infrastructure, I don't think anyone (but me and possibly Alex) is going to try it... :-) Stefan Paetow Moonshot Industry & Research Liaison Coordinator t: +44 (0)1235 822 125 gpg: 0x3FCE5142 xmpp: stefanp@jabber.dev.ja.net skype: stefan.paetow.janet jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800. On 11/11/2017, 16:01, "Freeradius-Users on behalf of Stefan Paetow" <freeradius-users-bounces+stefan.paetow=jisc.ac.uk@lists.freeradius.org on behalf of Stefan.Paetow@jisc.ac.uk> wrote: Right, I've submitted this 'at risk'... it compiles cleanly with trust router development libraries available. But whether it *works* is another question... Stefan Paetow Moonshot Industry & Research Liaison Coordinator t: +44 (0)1235 822 125 gpg: 0x3FCE5142 xmpp: stefanp@jabber.dev.ja.net skype: stefan.paetow.janet jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800. On 09/11/2017, 16:58, "Freeradius-Users on behalf of Stefan Paetow" <freeradius-users-bounces+stefan.paetow=jisc.ac.uk@lists.freeradius.org on behalf of Stefan.Paetow@jisc.ac.uk> wrote: > I messed up with git. This is the actual PR (https://github.com/FreeRADIUS/freeradius-server/pull/2114) Thanks, Alex! While I could generate my pull request, I really don't want to check this in and submit before testing it... since all the components that are involved in generating the GSS-EAP mechanism use OpenSSL 1.0.x, I am going down a rabbit hole where going to 1.1.x is concerned... Shall we proceed at risk? :-/ Stefan Paetow Moonshot Industry & Research Liaison Coordinator t: +44 (0)1235 822 125 gpg: 0x3FCE5142 xmpp: stefanp@jabber.dev.ja.net skype: stefan.paetow.janet jisc.ac.uk Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800. - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
participants (2)
-
Alejandro Pérez Méndez -
Stefan Paetow