freeradius3, rlm_preprocess changed defaults without notice
Hi. I am struggling moving our RADIUS server from freeradius 2.1 to freeradius 3 and found a (yet another) snag: rlm_preprocess in 2.1 does load huntgroups/users even they are not specified in configuration because it has defaults compiled in. Version 3, instead, needs them to be specified directly as have NULLs instead of default location: version 2: static const CONF_PARSER module_config[] = { { "huntgroups", PW_TYPE_FILENAME, offsetof(rlm_preprocess_t,huntgroup_file), NULL, "${raddbdir}/huntgroups" }, { "hints", PW_TYPE_FILENAME, offsetof(rlm_preprocess_t,hints_file), NULL, "${raddbdir}/hints" }, version 3: static const CONF_PARSER module_config[] = { { "huntgroups", FR_CONF_OFFSET(PW_TYPE_FILE_INPUT, rlm_preprocess_t, huntgroup_file), NULL }, { "hints", FR_CONF_OFFSET(PW_TYPE_FILE_INPUT, rlm_preprocess_t, hints_file), NULL }, This is not mentioned in "Changed modules" here: http://networkradius.com/doc/3.0.10/upgrading/changed-modules.html and adds a cherry on the top of migrating hell pie. Please find a way to fix it properly. -- Boris Lytochkin Yandex NOC +7 (495) 739 70 00 ext. 7671
Hi,
Version 3, instead, needs them to be specified directly as have NULLs instead of default location:
the default config works - and the files are read from the right location - there are even softlinked files present to ensure right file is edited if you are stuck in old ways. you cant take a 2.x config and slap it onto a 3.x server. they are not compatible. 2 -> 3 is a re-write config task. alan
Hi. I know default configuration works but still default behavior for module is changed and I expect a notice on it. In "Changed modules", not somewhere deep in configuration files. `Re-write config task' may be treated in a number of ways. A way I did it (copying over parts I need) is a way to do it. And it took a while (and RTFS finally) to understand what's going on. On 25.02.2016 15:10, A.L.M.Buxey@lboro.ac.uk wrote:
Hi,
Version 3, instead, needs them to be specified directly as have NULLs instead of default location: the default config works - and the files are read from the right location - there are even softlinked files present to ensure right file is edited if you are stuck in old ways.
you cant take a 2.x config and slap it onto a 3.x server. they are not compatible. 2 -> 3 is a re-write config task.
alan - List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html
-- Boris Lytochkin Yandex NOC +7 (495) 739 70 00 ext. 7671
On Feb 25, 2016, at 6:49 AM, Boris Lytochkin <lytboris@yandex-team.ru> wrote:
I am struggling moving our RADIUS server from freeradius 2.1 to freeradius 3 and found a (yet another) snag: rlm_preprocess in 2.1 does load huntgroups/users even they are not specified in configuration because it has defaults compiled in. Version 3, instead, needs them to be specified directly as have NULLs instead of default location:
The point is that it's perfectly fine to use the "preprocess" module without the hunt group functionality. If your configuration does *not* have "huntgroups" defined, your configuration was wrong. The point of configuration files is to specify what the server does. If the configuration files are randomly empty... they're wrong.
This is not mentioned in "Changed modules" here: http://networkradius.com/doc/3.0.10/upgrading/changed-modules.html and adds a cherry on the top of migrating hell pie.
Is that necessary? There are really small changes between v2 and v3. It should be relatively easy to migrate a system. You need to be careful, and test it, and read the debug output.. but it's just work.
Please find a way to fix it properly.
Use a correct configuration. Alan DeKok.
On 25.02.2016 16:32, Alan DeKok wrote:
On Feb 25, 2016, at 6:49 AM, Boris Lytochkin <lytboris@yandex-team.ru> wrote:
I am struggling moving our RADIUS server from freeradius 2.1 to freeradius 3 and found a (yet another) snag: rlm_preprocess in 2.1 does load huntgroups/users even they are not specified in configuration because it has defaults compiled in. Version 3, instead, needs them to be specified directly as have NULLs instead of default location: The point is that it's perfectly fine to use the "preprocess" module without the hunt group functionality.
If your configuration does *not* have "huntgroups" defined, your configuration was wrong. The thing is it *was not* wrong and there is no explicit notice about this change anywhere except code. I am not sure if a random freeradius user is capable of reading source code or write a rlm_ module :).
The point of configuration files is to specify what the server does. If the configuration files are randomly empty... they're wrong.
This is not mentioned in "Changed modules" here: http://networkradius.com/doc/3.0.10/upgrading/changed-modules.html and adds a cherry on the top of migrating hell pie. Is that necessary? There are really small changes between v2 and v3. Yes, it is, really. I did read it though and fixed everything that was mentioned either there or during test runs of radiusd -X. (field note - it would be really helpful for migration to have a way to run radiusd showing all issues in configuration all together)
It should be relatively easy to migrate a system. We'll see. I hope so.
Please find a way to fix it properly. Use a correct configuration. Update documentation :).
-- Boris Lytochkin Yandex NOC +7 (495) 739 70 00 ext. 7671
On Feb 25, 2016, at 8:39 AM, Boris Lytochkin <lytboris@yandex-team.ru> wrote:
The thing is it *was not* wrong and there is no explicit notice about this change anywhere except code. I am not sure if a random freeradius user is capable of reading source code or write a rlm_ module :).
The point is that the configuration files are meant to store the servers configuration. If you're not tracking the server configuration in the configuration files.. that's not a good thing.
Update documentation :).
<shrug> It's free to sign up to github. Send a pull request. We get a LOT of people asking for changes. I'd prefer if people *contribute* instead of asking *us* to make all of the changes. Alan DeKok.
Hi. On 25.02.2016 16:44, Alan DeKok wrote:
<shrug> It's free to sign up to github. Send a pull request. We get a LOT of people asking for changes. I'd prefer if people *contribute* instead of asking *us* to make all of the changes. Sounds reasonable. Here you go: https://github.com/FreeRADIUS/freeradius-server/pull/1548
-- Boris Lytochkin Yandex NOC +7 (495) 739 70 00 ext. 7671
Hi. Thanks for merging in. One more question: will it go automatically to http://networkradius.com/doc/3.0.10/upgrading/changed-modules.html ? I guess some pages on freeradius.org are referencing it. On 25.02.2016 21:14, Boris Lytochkin wrote:
Hi.
On 25.02.2016 16:44, Alan DeKok wrote:
<shrug> It's free to sign up to github. Send a pull request. We get a LOT of people asking for changes. I'd prefer if people *contribute* instead of asking *us* to make all of the changes. Sounds reasonable. Here you go: https://github.com/FreeRADIUS/freeradius-server/pull/1548
-- Boris Lytochkin Yandex NOC +7 (495) 739 70 00 ext. 7671
Hi,
http://networkradius.com/doc/3.0.10/upgrading/changed-modules.html ?
since those docs are for 3.0.10, then no - it'd be in 3.0.12 release alan
participants (3)
-
A.L.M.Buxey＠lboro.ac.uk -
Alan DeKok -
Boris Lytochkin