ippool: not found -> not sending reply
Hi, I have in 'users' two kinds of users - one with static IP assignments (Framed-IP-Address) and one with ippool. The issues comes with those 'static' users - when accounting stop happens, ippool behaves in the following way: (16) main_pool: EXPAND %{NAS-IP-Address} %{NAS-Port} (16) main_pool: --> xxx.xxx.xx.xx 892625506 (16) main_pool: MD5 on 'key' directive maps to: bc959cb51c2c3d41c93f922f572ee1d9 (16) main_pool: Searching for an entry for key: 'xxx.xxx.xx.xx 892625506' (16) main_pool: Entry not found (16) [main_pool] = notfound (16) } # accounting = notfound *(16) Not sending reply to client.* it _looks_ as it has no consequences except timeouts and resends on NAS side, but I don't like error-like behaviour. So I was able to fix this with the following statement in 'accounting' section (which is responsible for freeing the lease): redundant { main_pool ok } so regardless of main_pool's error, always return ok. But I have a question - while this is not leasing, but freeing of the lease, whether such rough override can impact something else? Whether it's make sense to add more granular control like "if main_pool returns notfound then it's ok" ? And, sorry for this - how it can be written using unlang? Thank you. -- Volodymyr Litovka "Vision without Execution is Hallucination." -- Thomas Edison
On Dec 27, 2022, at 10:53 AM, Volodymyr Litovka via Freeradius-Users <freeradius-users@lists.freeradius.org> wrote:
Hi,
I have in 'users' two kinds of users - one with static IP assignments (Framed-IP-Address) and one with ippool. The issues comes with those 'static' users - when accounting stop happens, ippool behaves in the following way:
The solution is to not run the ippool module for static IPs.
it _looks_ as it has no consequences except timeouts and resends on NAS side, but I don't like error-like behaviour. So I was able to fix this with the following statement in 'accounting' section (which is responsible for freeing the lease):
redundant { main_pool ok }
Or better: main_pool if (notfound) { ok } That was if the ippool module returns "fail", the packet will still fail.
so regardless of main_pool's error, always return ok.
But I have a question - while this is not leasing, but freeing of the lease, whether such rough override can impact something else? Whether it's make sense to add more granular control like "if main_pool returns notfound then it's ok" ? And, sorry for this - how it can be written using unlang?
Every module is independent. So if one module doesn't do anything, it doesn't affect anything else. Alan DeKok.
Hi, On 27.12.2022 22:02, Alan DeKok wrote:
On Dec 27, 2022, at 10:53 AM, Volodymyr Litovka via Freeradius-Users <freeradius-users@lists.freeradius.org> wrote:
Hi,
I have in 'users' two kinds of users - one with static IP assignments (Framed-IP-Address) and one with ippool. The issues comes with those 'static' users - when accounting stop happens, ippool behaves in the following way: The solution is to not run the ippool module for static IPs.
I'd like to not run, but the users and config are independent, so I have in users smth like aaa Pool-Name := main_pool, Clear... ... bbb Cleartext-Password := "bbb" ... while sites-enabled/default is common for both records and process both kinds of users - 'aaa' and 'bbb'.
Every module is independent. So if one module doesn't do anything, it doesn't affect anything else.
Thanks again, I very hope it was a last question this year :) Happy new year! -- Volodymyr Litovka "Vision without Execution is Hallucination." -- Thomas Edison
participants (2)
-
Alan DeKok -
Volodymyr Litovka