Re: rlm_sql_null holding locks and hanging radsqlrelay.
Alan, Last year you directed me to patch rad_unlockfd() to use F_UNLCK instead of F_WRLCK. I did that and things have been stable, but while building the latest patches for 3.0.20 I noticed that the 3.0.x branch still uses F_WRLCK. Any reason that this change hasn't made it to the 3.0.x branch? I would have thought that would be something I'd see in the next release. Thanks, schu On 8/1/18 2:12 PM, Alan DeKok wrote:
Nope. The rad_unlockfd() function didn't use F_UNLCK. Instead it used F_WRLCK.
That was a bug which has been around for a *long* time. :(
On Aug 1, 2018, at 4:36 PM, Matthew Schumacher <matt.s@aptalaska.net> wrote:
On 8/1/18 12:28 PM, Alan DeKok wrote:
Grab the code from git, v3.0.x branch. Matthew Newton found a tiny but rather shocking little bug. :( Is this what you are talking about?
https://github.com/mcnewton/freeradius-server/commit/8cf46c98e336a69894d2470...
Thanks, schu
On Thu, 2019-11-14 at 14:45 -0800, Matthew Schumacher wrote:
Last year you directed me to patch rad_unlockfd() to use F_UNLCK instead of F_WRLCK. I did that and things have been stable, but while building the latest patches for 3.0.20 I noticed that the 3.0.x branch still uses F_WRLCK. Any reason that this change hasn't made it to the 3.0.x branch? I would have thought that would be something I'd see in the next release.
What makes you think that? https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/lib/misc.c#L... -- Matthew
On 11/14/19 4:58 PM, Matthew Newton wrote:
On Thu, 2019-11-14 at 14:45 -0800, Matthew Schumacher wrote:
Last year you directed me to patch rad_unlockfd() to use F_UNLCK instead of F_WRLCK. I did that and things have been stable, but while building the latest patches for 3.0.20 I noticed that the 3.0.x branch still uses F_WRLCK. What makes you think that?
https://github.com/FreeRADIUS/freeradius-server/blob/v3.0.x/src/lib/misc.c#L...
Oh, I see what the problem is, my patch worked with offset so I assumed the code wasn't changed: patching file src/lib/misc.c Hunk #1 succeeded at 783 (offset -7 lines). But patch got confused and changed rad_lockfd_nonblock(). Thanks for responding.
participants (2)
-
Matthew Newton -
Matthew Schumacher