[PATCH] rlm_python fixes

Alan DeKok aland at ox.org
Tue Jan 17 18:29:09 CET 2006


Paul P Komkoff Jr <i at stingr.net> wrote:
> Please consider applying the following patch to rlm_python.c

  Hmm... see bugs.freeradius.org for yet another patch to the python
module.

  The main problem I have with your patch is that I can't tell what's
changed.  You've mixed up re-formatting, re-arrangement, and new code
all in the same patch.

  If you could send a series of patches, each doing *one* thing, it
would be a lot easier to tell what the code does.

  And that would allow us to separate what appears to be gratuitous
re-arrangement from bug fixes.

  Alan DeKok.



More information about the Freeradius-Devel mailing list