Should MAX_STRING_LEN be 253?

[Alan DeKok]

Makarand Pradhan wrote:
> As the constant MAX_STRING_LEN is being used in our code to split a big
> EAP message into multiple segments, we tend to loose one byte in every
> segment causing authentication failure (malformed packet received).

  Your code is wrong... it should be splitting EAP messages every 253
octets.

> Question:
> Based on the above analysis it was felt that the constant should be 253.
> Should the constant be changed to 253 or is there any other reason for
> keeping it at 254?

  The constant is 254 for reasons internal to FreeRADIUS.

  Alan DeKok.